Re: [libvirt] [PATCH 06/15] Forward Mode 'Hostdev' qemu driver implementation

2012-08-15 Thread Shradha Shah
On 08/14/2012 07:44 AM, Laine Stump wrote: On 08/10/2012 12:24 PM, Shradha Shah wrote: Some explanation is needed in the commit log of what this is being done here. A cut-paste of the comment in the code would be a good start (any anyway, that comment can be changed since it's talking about

Re: [libvirt] [PATCH 06/15] Forward Mode 'Hostdev' qemu driver implementation

2012-08-15 Thread Laine Stump
On 08/15/2012 06:43 AM, Shradha Shah wrote: On 08/14/2012 07:44 AM, Laine Stump wrote: On 08/10/2012 12:24 PM, Shradha Shah wrote: + (def-nhostdevs-1)) 0) { +virReportError(VIR_ERR_INTERNAL_ERROR, %s, +

Re: [libvirt] [PATCH 06/15] Forward Mode 'Hostdev' qemu driver implementation

2012-08-14 Thread Laine Stump
On 08/10/2012 12:24 PM, Shradha Shah wrote: Some explanation is needed in the commit log of what this is being done here. A cut-paste of the comment in the code would be a good start (any anyway, that comment can be changed since it's talking about when there is a network with forward

[libvirt] [PATCH 06/15] Forward Mode 'Hostdev' qemu driver implementation

2012-08-10 Thread Shradha Shah
Signed-off-by: Shradha Shah ss...@solarflare.com --- src/qemu/qemu_command.c | 27 +++ 1 files changed, 27 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 6f6c6cd..bb66364 100644 --- a/src/qemu/qemu_command.c +++