Re: [libvirt] [PATCH 1/1] Clear PIIX3/PIIX4_USB capabilities for non-X86 platforms

2013-02-28 Thread Jiri Denemark
On Thu, Feb 28, 2013 at 10:39:56 +0800, Li Zhang wrote: On Thu, Feb 28, 2013 at 10:06 AM, Li Zhang zhlci...@gmail.com wrote: I also hope that QEMU capabilities depend on the binary by QMP. But the flags in virQEMUCapsObjectTypes are all set in virQEMUCapsInitQMP. virQEMUCapsInitQMP -

Re: [libvirt] [PATCH 1/1] Clear PIIX3/PIIX4_USB capabilities for non-X86 platforms

2013-02-28 Thread Li Zhang
On 2013年02月28日 19:39, Jiri Denemark wrote: On Thu, Feb 28, 2013 at 10:39:56 +0800, Li Zhang wrote: On Thu, Feb 28, 2013 at 10:06 AM, Li Zhang zhlci...@gmail.com wrote: I also hope that QEMU capabilities depend on the binary by QMP. But the flags in virQEMUCapsObjectTypes are all set in

Re: [libvirt] [PATCH 1/1] Clear PIIX3/PIIX4_USB capabilities for non-X86 platforms

2013-02-28 Thread Jiri Denemark
On Thu, Feb 28, 2013 at 19:47:47 +0800, Li Zhang wrote: On 2013年02月28日 19:39, Jiri Denemark wrote: I tried to execute qom-list-types command, I get a lot of return values including X86 and other platforms. I think this is the real problem. QEMU binary emulating PPC architecture should

Re: [libvirt] [PATCH 1/1] Clear PIIX3/PIIX4_USB capabilities for non-X86 platforms

2013-02-28 Thread Li Zhang
On 2013年02月28日 19:47, Li Zhang wrote: On 2013年02月28日 19:39, Jiri Denemark wrote: On Thu, Feb 28, 2013 at 10:39:56 +0800, Li Zhang wrote: On Thu, Feb 28, 2013 at 10:06 AM, Li Zhang zhlci...@gmail.com wrote: It seems that command qom-list-types just give all architectures' list, not

[libvirt] [PATCH 1/1] Clear PIIX3/PIIX4_USB capabilities for non-X86 platforms

2013-02-27 Thread Li Zhang
From: Li Zhang zhlci...@linux.vnet.ibm.com Currently, PIIX3/PIIX4_USB capabilities are enabled for other platforms. Actually, it is only supported for X86. So this patch is to clear the capabilities for non-X86 platforms. Signed-off-by: Li Zhang zhlci...@linux.vnet.ibm.com ---

Re: [libvirt] [PATCH 1/1] Clear PIIX3/PIIX4_USB capabilities for non-X86 platforms

2013-02-27 Thread Li Zhang
Hi Eric, This is also one bug-fix, could you help review and push to 1.0.3? Thanks. :-) On Wed, Feb 27, 2013 at 7:52 PM, Li Zhang zhlci...@gmail.com wrote: From: Li Zhang zhlci...@linux.vnet.ibm.com Currently, PIIX3/PIIX4_USB capabilities are enabled for other platforms. Actually, it is

Re: [libvirt] [PATCH 1/1] Clear PIIX3/PIIX4_USB capabilities for non-X86 platforms

2013-02-27 Thread Jiri Denemark
On Wed, Feb 27, 2013 at 19:52:22 +0800, Li Zhang wrote: From: Li Zhang zhlci...@linux.vnet.ibm.com Currently, PIIX3/PIIX4_USB capabilities are enabled for other platforms. Actually, it is only supported for X86. So this patch is to clear the capabilities for non-X86 platforms. ... diff

Re: [libvirt] [PATCH 1/1] Clear PIIX3/PIIX4_USB capabilities for non-X86 platforms

2013-02-27 Thread Li Zhang
I also hope that QEMU capabilities depend on the binary by QMP. But the flags in virQEMUCapsObjectTypes are all set in virQEMUCapsInitQMP. virQEMUCapsInitQMP - virQEMUCapsProbeQMPObjects - virQEMUCapsProcessStringFlags(qemuCaps,

Re: [libvirt] [PATCH 1/1] Clear PIIX3/PIIX4_USB capabilities for non-X86 platforms

2013-02-27 Thread Li Zhang
On Thu, Feb 28, 2013 at 10:06 AM, Li Zhang zhlci...@gmail.com wrote: I also hope that QEMU capabilities depend on the binary by QMP. But the flags in virQEMUCapsObjectTypes are all set in virQEMUCapsInitQMP. virQEMUCapsInitQMP - virQEMUCapsProbeQMPObjects -