Re: [libvirt] [PATCH 1/1] conf: handle empty string in interface target name

2019-09-26 Thread Nikolay Shirokovskiy
On 25.09.2019 15:52, Peter Krempa wrote: > On Wed, Sep 25, 2019 at 12:42:07 +, Nikolay Shirokovskiy wrote: >> >> >> On 23.09.2019 17:44, Peter Krempa wrote: >>> On Mon, Sep 23, 2019 at 11:21:33 -0300, Daniel Henrique Barboza wrote: On 9/23/19 8:55 AM, Nikolay Shirokovskiy

Re: [libvirt] [PATCH 1/1] conf: handle empty string in interface target name

2019-09-25 Thread Peter Krempa
On Wed, Sep 25, 2019 at 12:42:07 +, Nikolay Shirokovskiy wrote: > > > On 23.09.2019 17:44, Peter Krempa wrote: > > On Mon, Sep 23, 2019 at 11:21:33 -0300, Daniel Henrique Barboza wrote: > >> > >> > >> On 9/23/19 8:55 AM, Nikolay Shirokovskiy wrote: > >>> Empty name is not allowed by schema

Re: [libvirt] [PATCH 1/1] conf: handle empty string in interface target name

2019-09-25 Thread Nikolay Shirokovskiy
On 23.09.2019 17:44, Peter Krempa wrote: > On Mon, Sep 23, 2019 at 11:21:33 -0300, Daniel Henrique Barboza wrote: >> >> >> On 9/23/19 8:55 AM, Nikolay Shirokovskiy wrote: >>> Empty name is not allowed by schema but qemu is able to start with such >>> a config (and I guess some other hypervisors

Re: [libvirt] [PATCH 1/1] conf: handle empty string in interface target name

2019-09-23 Thread Peter Krempa
On Mon, Sep 23, 2019 at 11:21:33 -0300, Daniel Henrique Barboza wrote: > > > On 9/23/19 8:55 AM, Nikolay Shirokovskiy wrote: > > Empty name is not allowed by schema but qemu is able to start with such > > a config (and I guess some other hypervisors too). As a result name will > > be generated

Re: [libvirt] [PATCH 1/1] conf: handle empty string in interface target name

2019-09-23 Thread Daniel Henrique Barboza
On 9/23/19 8:55 AM, Nikolay Shirokovskiy wrote: Empty name is not allowed by schema but qemu is able to start with such a config (and I guess some other hypervisors too). As a result name will be generated by kernel and have form 'tap'. At the same time if target element is ommited in config

[libvirt] [PATCH 1/1] conf: handle empty string in interface target name

2019-09-23 Thread Nikolay Shirokovskiy
Empty name is not allowed by schema but qemu is able to start with such a config (and I guess some other hypervisors too). As a result name will be generated by kernel and have form 'tap'. At the same time if target element is ommited in config the name will be generated by libvirt and have form