Re: [libvirt] [PATCH 1/2] Revert "network: Check for QOS before blindly using it"

2019-11-25 Thread Michal Privoznik
On 11/24/19 9:12 PM, Julio Faracco wrote: Em sex., 22 de nov. de 2019 às 14:09, Erik Skultety escreveu: This reverts commit f4db846c32c0a1e99a0f62b340273e48f8a98ed3. This patch results in the following error when trying to start essentially any VM with default network: This kind of issue

Re: [libvirt] [PATCH 1/2] Revert "network: Check for QOS before blindly using it"

2019-11-25 Thread Michal Privoznik
On 11/22/19 5:08 PM, Erik Skultety wrote: This reverts commit f4db846c32c0a1e99a0f62b340273e48f8a98ed3. This patch results in the following error when trying to start essentially any VM with default network: unsupported configuration: QOS must be defined for network 'default' Coverity didn't

Re: [libvirt] [PATCH 1/2] Revert "network: Check for QOS before blindly using it"

2019-11-25 Thread Erik Skultety
On Sun, Nov 24, 2019 at 06:12:58PM -0200, Julio Faracco wrote: > Em sex., 22 de nov. de 2019 às 14:09, Erik Skultety > escreveu: > > > > This reverts commit f4db846c32c0a1e99a0f62b340273e48f8a98ed3. > > > > This patch results in the following error when trying to start > > essentially any VM with

Re: [libvirt] [PATCH 1/2] Revert "network: Check for QOS before blindly using it"

2019-11-25 Thread Jiri Denemark
On Fri, Nov 22, 2019 at 17:08:59 +0100, Erik Skultety wrote: > This reverts commit f4db846c32c0a1e99a0f62b340273e48f8a98ed3. > > This patch results in the following error when trying to start > essentially any VM with default network: > > unsupported configuration: QOS must be defined for

Re: [libvirt] [PATCH 1/2] Revert "network: Check for QOS before blindly using it"

2019-11-24 Thread Julio Faracco
Em sex., 22 de nov. de 2019 às 14:09, Erik Skultety escreveu: > > This reverts commit f4db846c32c0a1e99a0f62b340273e48f8a98ed3. > > This patch results in the following error when trying to start > essentially any VM with default network: This kind of issue should be caught by test driver,

Re: [libvirt] [PATCH 1/2] Revert "network: Check for QOS before blindly using it"

2019-11-22 Thread Daniel Henrique Barboza
On 11/22/19 1:08 PM, Erik Skultety wrote: This reverts commit f4db846c32c0a1e99a0f62b340273e48f8a98ed3. This patch results in the following error when trying to start essentially any VM with default network: unsupported configuration: QOS must be defined for network 'default' Coverity

[libvirt] [PATCH 1/2] Revert "network: Check for QOS before blindly using it"

2019-11-22 Thread Erik Skultety
This reverts commit f4db846c32c0a1e99a0f62b340273e48f8a98ed3. This patch results in the following error when trying to start essentially any VM with default network: unsupported configuration: QOS must be defined for network 'default' Coverity didn't see that the bandwidth == NULL it complained