Re: [libvirt] [PATCH 1/2] virsh: Pass vshControl to all vshCommandOpt*() calls.

2015-05-21 Thread Andrea Bolognani
On Thu, 2015-05-21 at 13:22 +0200, Peter Krempa wrote: > > -vshCommandOpt(const vshCmd *cmd, const char *name, vshCmdOpt **opt, > > +vshCommandOpt(vshControl *ctl ATTRIBUTE_UNUSED, const vshCmd *cmd, > > + const char *name, vshCmdOpt **opt, > >bool needData) > > So th

Re: [libvirt] [PATCH 1/2] virsh: Pass vshControl to all vshCommandOpt*() calls.

2015-05-21 Thread Peter Krempa
On Thu, May 21, 2015 at 11:40:26 +0200, Andrea Bolognani wrote: > This will allow us to use vshError() to report errors from inside > vshCommandOpt*(), instead of replicating the same logic and error > messages all over the place. > > We also have more context inside the vshCommandOpt*() functions

[libvirt] [PATCH 1/2] virsh: Pass vshControl to all vshCommandOpt*() calls.

2015-05-21 Thread Andrea Bolognani
This will allow us to use vshError() to report errors from inside vshCommandOpt*(), instead of replicating the same logic and error messages all over the place. We also have more context inside the vshCommandOpt*() functions, for example the actual value used on the command line, which means we ca