Re: [libvirt] [PATCH 1/2 RESEND] qemu: refactor graphics code to not hardcode a single display

2012-11-09 Thread Alon Levy
hmm, I'm not using the enum everywhere, I'll send again after fixing (and use --patience). - Original Message - From: Alon Levy al...@redhat.com The check for a single display remains so no new functionality is added. --- No change to the patch itself, just the use of the

Re: [libvirt] [PATCH 1/2 RESEND] qemu: refactor graphics code to not hardcode a single display

2012-11-09 Thread Jiri Denemark
On Fri, Nov 09, 2012 at 05:14:10 -0500, Alon Levy wrote: hmm, I'm not using the enum everywhere, I'll send again after fixing (and use --patience). Actually it's be better to just get rid of the enum completely and rather follow libvirt's convention of returning -1 on error and 0 on success.

[libvirt] [PATCH 1/2 RESEND] qemu: refactor graphics code to not hardcode a single display

2012-11-08 Thread Eric Blake
From: Alon Levy al...@redhat.com The check for a single display remains so no new functionality is added. --- No change to the patch itself, just the use of the --patience flag to make review much easier. src/qemu/qemu_command.c | 647 +---