Re: [libvirt] [PATCH 1/3] conf: Set rebootTimeout valid range to 0..0xffff

On Tue, Nov 12, 2019 at 5:15 PM Markus Armbruster wrote: > I apologize for my slooow response; KVM Forum happened. > It doesn't matter. I attended KVM forum, too :) > > Han Han writes: > > > On Tue, Oct 15, 2019 at 4:04 PM Michal Privoznik > > wrote: > > > >> On 10/15/19 7:23 AM, Han Han

Re: [libvirt] [PATCH 1/3] conf: Set rebootTimeout valid range to 0..0xffff

I apologize for my slooow response; KVM Forum happened. Han Han writes: > On Tue, Oct 15, 2019 at 4:04 PM Michal Privoznik > wrote: > >> On 10/15/19 7:23 AM, Han Han wrote: >> > Hi Michal, >> > Any more advice update? >> >> Well, as I've said earlier, since we document that -1 is accepted

Re: [libvirt] [PATCH 1/3] conf: Set rebootTimeout valid range to 0..0xffff

On Tue, Oct 15, 2019 at 4:04 PM Michal Privoznik wrote: > On 10/15/19 7:23 AM, Han Han wrote: > > Hi Michal, > > Any more advice update? > > Well, as I've said earlier, since we document that -1 is accepted value > and it means that it suppresses automatic reboots we need a way to > preserve

Re: [libvirt] [PATCH 1/3] conf: Set rebootTimeout valid range to 0..0xffff

On 10/15/19 7:23 AM, Han Han wrote: Hi Michal, Any more advice update? Well, as I've said earlier, since we document that -1 is accepted value and it means that it suppresses automatic reboots we need a way to preserve this behaviour. For instance, what happens if you don't put

Re: [libvirt] [PATCH 1/3] conf: Set rebootTimeout valid range to 0..0xffff

Hi Michal, Any more advice update? On Tue, Oct 8, 2019 at 8:42 PM Han Han wrote: > > > On Tue, Oct 8, 2019 at 5:50 PM Michal Privoznik > wrote: > >> On 10/8/19 10:36 AM, Han Han wrote: >> > Adjust valid range of rebootTimeout according to qemu-4.0.0 commit >> > ee5d0f89de3. >> > >> >

Re: [libvirt] [PATCH 1/3] conf: Set rebootTimeout valid range to 0..0xffff

On Tue, Oct 8, 2019 at 5:50 PM Michal Privoznik wrote: > On 10/8/19 10:36 AM, Han Han wrote: > > Adjust valid range of rebootTimeout according to qemu-4.0.0 commit > > ee5d0f89de3. > > > > Signed-off-by: Han Han > > --- > > src/conf/domain_conf.c | 6 -- > > 1 file changed, 4

Re: [libvirt] [PATCH 1/3] conf: Set rebootTimeout valid range to 0..0xffff

On 10/8/19 10:36 AM, Han Han wrote: Adjust valid range of rebootTimeout according to qemu-4.0.0 commit ee5d0f89de3. Signed-off-by: Han Han --- src/conf/domain_conf.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c

[libvirt] [PATCH 1/3] conf: Set rebootTimeout valid range to 0..0xffff

Adjust valid range of rebootTimeout according to qemu-4.0.0 commit ee5d0f89de3. Signed-off-by: Han Han --- src/conf/domain_conf.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index a53cd6a725..57ab254f52 100644 ---