Re: [libvirt] [PATCH 1/3] util: Add a helper to check if all bits of a bitmap are clear

2013-04-02 Thread John Ferlan
On 04/02/2013 01:42 AM, Osier Yang wrote: --- src/libvirt_private.syms | 1 + src/util/virbitmap.c | 30 ++ src/util/virbitmap.h | 3 +++ 3 files changed, 34 insertions(+) Since there already is a virBitmapIsAllSet() - why isn't it used? I see

Re: [libvirt] [PATCH 1/3] util: Add a helper to check if all bits of a bitmap are clear

2013-04-02 Thread Daniel P. Berrange
On Tue, Apr 02, 2013 at 06:52:22AM -0400, John Ferlan wrote: On 04/02/2013 01:42 AM, Osier Yang wrote: --- src/libvirt_private.syms | 1 + src/util/virbitmap.c | 30 ++ src/util/virbitmap.h | 3 +++ 3 files changed, 34 insertions(+) Since

Re: [libvirt] [PATCH 1/3] util: Add a helper to check if all bits of a bitmap are clear

2013-04-02 Thread Osier Yang
On 02/04/13 18:52, John Ferlan wrote: On 04/02/2013 01:42 AM, Osier Yang wrote: --- src/libvirt_private.syms | 1 + src/util/virbitmap.c | 30 ++ src/util/virbitmap.h | 3 +++ 3 files changed, 34 insertions(+) Since there already is a

Re: [libvirt] [PATCH 1/3] util: Add a helper to check if all bits of a bitmap are clear

2013-04-02 Thread Eric Blake
On 04/01/2013 11:42 PM, Osier Yang wrote: --- src/libvirt_private.syms | 1 + src/util/virbitmap.c | 30 ++ src/util/virbitmap.h | 3 +++ 3 files changed, 34 insertions(+) +bool virBitmapIsAllClear(virBitmapPtr bitmap) +{ +int i; +int

[libvirt] [PATCH 1/3] util: Add a helper to check if all bits of a bitmap are clear

2013-04-01 Thread Osier Yang
--- src/libvirt_private.syms | 1 + src/util/virbitmap.c | 30 ++ src/util/virbitmap.h | 3 +++ 3 files changed, 34 insertions(+) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 96eea0a..35ac957 100644 --- a/src/libvirt_private.syms