Re: [libvirt] [PATCH 1/4] qemu: domain: gfx: Fix shadowing the ptr argument to graphics validation

2018-12-12 Thread Erik Skultety
On Tue, Dec 11, 2018 at 06:48:26PM -0500, John Ferlan wrote: > > > On 12/7/18 9:47 AM, Erik Skultety wrote: > > Since the code was never run, this stupid mistake could have only been > > spotted by an accident. > > > > Signed-off-by: Erik Skultety > > --- > > src/qemu/qemu_domain.c | 4 +--- > >

Re: [libvirt] [PATCH 1/4] qemu: domain: gfx: Fix shadowing the ptr argument to graphics validation

2018-12-11 Thread John Ferlan
On 12/7/18 9:47 AM, Erik Skultety wrote: > Since the code was never run, this stupid mistake could have only been > spotted by an accident. > > Signed-off-by: Erik Skultety > --- > src/qemu/qemu_domain.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > Gah - that wasn't

[libvirt] [PATCH 1/4] qemu: domain: gfx: Fix shadowing the ptr argument to graphics validation

2018-12-07 Thread Erik Skultety
Since the code was never run, this stupid mistake could have only been spotted by an accident. Signed-off-by: Erik Skultety --- src/qemu/qemu_domain.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index