Re: [libvirt] [PATCH 1/4] travis: add a scenario for running make distcheck

2018-02-27 Thread Daniel P . Berrangé
On Tue, Feb 27, 2018 at 04:53:17PM +0100, Andrea Bolognani wrote: > On Tue, 2018-02-27 at 15:41 +, Daniel P. Berrangé wrote: > > > > Running syntax-check in all 5 scenarios isn't buying us anything, > > > > as the syntax-check rules don't depend on what is installed in the > > > > host. IOW,

Re: [libvirt] [PATCH 1/4] travis: add a scenario for running make distcheck

2018-02-27 Thread Andrea Bolognani
On Tue, 2018-02-27 at 15:41 +, Daniel P. Berrangé wrote: > > > Running syntax-check in all 5 scenarios isn't buying us anything, > > > as the syntax-check rules don't depend on what is installed in the > > > host. IOW, running syntax-check in 1 scenario is sufficient to get > > > us the

Re: [libvirt] [PATCH 1/4] travis: add a scenario for running make distcheck

2018-02-27 Thread Daniel P . Berrangé
On Tue, Feb 27, 2018 at 04:35:32PM +0100, Andrea Bolognani wrote: > On Tue, 2018-02-27 at 15:06 +, Daniel P. Berrangé wrote: > > > > - compiler: gcc > > > >dist: precise > > > > +# Special scenario to run distcheck, so we don't waste time > > > > duplicating > > > > +#

Re: [libvirt] [PATCH 1/4] travis: add a scenario for running make distcheck

2018-02-27 Thread Andrea Bolognani
On Tue, 2018-02-27 at 15:06 +, Daniel P. Berrangé wrote: > > > - compiler: gcc > > >dist: precise > > > +# Special scenario to run distcheck, so we don't waste time > > > duplicating > > > +# work in all the other scenarios. Doesn't work on precise due to the > > > +#

Re: [libvirt] [PATCH 1/4] travis: add a scenario for running make distcheck

2018-02-27 Thread Daniel P . Berrangé
On Tue, Feb 27, 2018 at 04:02:19PM +0100, Andrea Bolognani wrote: > On Fri, 2018-02-23 at 12:00 +, Daniel P. Berrangé wrote: > > Running "make distcheck" ensures that we have CLEANFILES and uninstall > > rules setup correctly, as well as validating VPATH builds succeeed. > > > >

Re: [libvirt] [PATCH 1/4] travis: add a scenario for running make distcheck

2018-02-27 Thread Andrea Bolognani
On Fri, 2018-02-23 at 12:00 +, Daniel P. Berrangé wrote: > Running "make distcheck" ensures that we have CLEANFILES and uninstall > rules setup correctly, as well as validating VPATH builds succeeed. > > Signed-off-by: Daniel P. Berrangé > --- > .travis.yml | 5 + >

[libvirt] [PATCH 1/4] travis: add a scenario for running make distcheck

2018-02-23 Thread Daniel P . Berrangé
Running "make distcheck" ensures that we have CLEANFILES and uninstall rules setup correctly, as well as validating VPATH builds succeeed. Signed-off-by: Daniel P. Berrangé --- .travis.yml | 5 + 1 file changed, 5 insertions(+) diff --git a/.travis.yml b/.travis.yml