Re: [libvirt] [PATCH 13/42] util: Use g_autofree on virLogSetDefaultOutputToFile()

[Ján Tomko]

s/on/in/

On Thu, Dec 19, 2019 at 11:04:18AM +0100, Fabiano Fidêncio wrote:

Signed-off-by: Fabiano Fidêncio 
---
src/util/virlog.c | 12 
1 file changed, 4 insertions(+), 8 deletions(-)



Reviewed-by: Ján Tomko 

Jano


signature.asc
Description: PGP signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 13/42] util: Use g_autofree on virLogSetDefaultOutputToFile()

[Fabiano Fidêncio]

Signed-off-by: Fabiano Fidêncio 
---
 src/util/virlog.c | 12 
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/src/util/virlog.c b/src/util/virlog.c
index d45e2dd316..10639d7328 100644
--- a/src/util/virlog.c
+++ b/src/util/virlog.c
@@ -173,8 +173,7 @@ virLogSetDefaultOutputToJournald(void)
 static int
 virLogSetDefaultOutputToFile(const char *binary, bool privileged)
 {
-int ret = -1;
-char *logdir = NULL;
+g_autofree char *logdir = NULL;
 mode_t old_umask;
 
 if (privileged) {
@@ -182,12 +181,12 @@ virLogSetDefaultOutputToFile(const char *binary, bool 
privileged)
   virLogDefaultPriority, 
LOCALSTATEDIR, binary);
 } else {
 if (!(logdir = virGetUserCacheDirectory()))
-goto cleanup;
+return -1;
 
 old_umask = umask(077);
 if (virFileMakePath(logdir) < 0) {
 umask(old_umask);
-goto cleanup;
+return -1;
 }
 umask(old_umask);
 
@@ -195,10 +194,7 @@ virLogSetDefaultOutputToFile(const char *binary, bool 
privileged)
   virLogDefaultPriority, logdir, 
binary);
 }
 
-ret = 0;
- cleanup:
-VIR_FREE(logdir);
-return ret;
+return 0;
 }
 
 
-- 
2.24.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list