Re: [libvirt] [PATCH 17/30] remote: Remove virConnectPtr from error/errorf

2010-04-12 Thread Dave Allan
On Fri, Apr 09, 2010 at 02:03:09AM +0200, Matthias Bolte wrote: 2010/4/5 Eric Blake ebl...@redhat.com: On 04/04/2010 11:36 AM, Matthias Bolte wrote: Also unify error/errorf to remoteError and update cfg.mk accordingly. +++ b/src/remote/remote_driver.c @@ -239,11 +239,9 @@ static int

Re: [libvirt] [PATCH 17/30] remote: Remove virConnectPtr from error/errorf

2010-04-12 Thread Eric Blake
On 04/12/2010 09:03 AM, Dave Allan wrote: +remoteError(VIR_ERR_INVALID_ARG, %s, +_(transport methods unix, ssh and ext are not supported + under Windows)); I see why you broke this line, to fit 80 columns, but that can impact grep-ability

Re: [libvirt] [PATCH 17/30] remote: Remove virConnectPtr from error/errorf

2010-04-08 Thread Matthias Bolte
2010/4/5 Eric Blake ebl...@redhat.com: On 04/04/2010 11:36 AM, Matthias Bolte wrote: Also unify error/errorf to remoteError and update cfg.mk accordingly. +++ b/src/remote/remote_driver.c @@ -239,11 +239,9 @@ static int remoteAuthSASL (virConnectPtr conn, struct private_data *priv, int in  

Re: [libvirt] [PATCH 17/30] remote: Remove virConnectPtr from error/errorf

2010-04-05 Thread Eric Blake
On 04/04/2010 11:36 AM, Matthias Bolte wrote: Also unify error/errorf to remoteError and update cfg.mk accordingly. +++ b/src/remote/remote_driver.c @@ -239,11 +239,9 @@ static int remoteAuthSASL (virConnectPtr conn, struct private_data *priv, int in static int remoteAuthPolkit