Re: [libvirt] [PATCH 2/2] qemu: migration: Set the 'set' boolean in qemuMigrationParamsSetString

2018-04-27 Thread Ján Tomko
On Fri, Apr 27, 2018 at 03:16:46PM +0200, Peter Krempa wrote: The code setting TLS parameters verifies that TLS is supported by looking at the dump of parameters which will be reset after migration, but sets the parameters in the list of new parameters. As qemuMigrationParamsSetString did not

Re: [libvirt] [PATCH 2/2] qemu: migration: Set the 'set' boolean in qemuMigrationParamsSetString

2018-04-27 Thread Daniel P . Berrangé
On Fri, Apr 27, 2018 at 03:16:46PM +0200, Peter Krempa wrote: > The code setting TLS parameters verifies that TLS is supported by > looking at the dump of parameters which will be reset after migration, > but sets the parameters in the list of new parameters. As > qemuMigrationParamsSetString did

[libvirt] [PATCH 2/2] qemu: migration: Set the 'set' boolean in qemuMigrationParamsSetString

2018-04-27 Thread Peter Krempa
The code setting TLS parameters verifies that TLS is supported by looking at the dump of parameters which will be reset after migration, but sets the parameters in the list of new parameters. As qemuMigrationParamsSetString did not set the 'set' property, the TLS parameters would not be used.