Re: [libvirt] [PATCH 2/2] security: SELinux: fix the transaction model's list append

2017-01-17 Thread Erik Skultety
> > @@ -111,21 +111,31 @@ > > virSecuritySELinuxContextListAppend(virSecuritySELinuxContextListPtr list, > > const char *tcon, > > bool optional) > > { > > -virSecuritySELinuxContextItemPtr item; > > +int ret = -1;

Re: [libvirt] [PATCH 2/2] security: SELinux: fix the transaction model's list append

2017-01-17 Thread Michal Privoznik
On 01/17/2017 02:56 PM, Erik Skultety wrote: > The problem is in the way how the list item is created prior to > appending it to the transaction list - the @path argument is just a > shallow copy instead of deep copy of the hostdev device's path. > Unfortunately, the hostdev devices from which the

[libvirt] [PATCH 2/2] security: SELinux: fix the transaction model's list append

2017-01-17 Thread Erik Skultety
The problem is in the way how the list item is created prior to appending it to the transaction list - the @path argument is just a shallow copy instead of deep copy of the hostdev device's path. Unfortunately, the hostdev devices from which the @path is extracted, in order to add them into the