Re: [libvirt] [PATCH 2/2] storage: Check qemu-img encryption type capability

2018-04-20 Thread Daniel P . Berrangé
On Thu, Apr 19, 2018 at 02:21:43PM -0400, John Ferlan wrote: > > [...] > > >> Oh, OK - well I didn't find that to be obvious... So there is a way > >> using secret objects to create a qcow[2] encrypted volume? > > > > Sure, the exact same syntax as with luks volumes - you just specify > >

Re: [libvirt] [PATCH 2/2] storage: Check qemu-img encryption type capability

2018-04-19 Thread John Ferlan
[...] >> Oh, OK - well I didn't find that to be obvious... So there is a way >> using secret objects to create a qcow[2] encrypted volume? > > Sure, the exact same syntax as with luks volumes - you just specify > "qcow" instead of "luks" as the type. > So I've been working on doing as

Re: [libvirt] [PATCH 2/2] storage: Check qemu-img encryption type capability

2018-04-18 Thread Daniel P . Berrangé
On Wed, Apr 18, 2018 at 08:53:09AM -0400, John Ferlan wrote: > > > On 04/18/2018 08:17 AM, Daniel P. Berrangé wrote: > > On Wed, Apr 18, 2018 at 08:08:41AM -0400, John Ferlan wrote: > >> > >> > >> On 04/18/2018 04:29 AM, Daniel P. Berrangé wrote: > >>> On Tue, Apr 17, 2018 at 03:23:33PM -0400,

Re: [libvirt] [PATCH 2/2] storage: Check qemu-img encryption type capability

2018-04-18 Thread John Ferlan
On 04/18/2018 08:17 AM, Daniel P. Berrangé wrote: > On Wed, Apr 18, 2018 at 08:08:41AM -0400, John Ferlan wrote: >> >> >> On 04/18/2018 04:29 AM, Daniel P. Berrangé wrote: >>> On Tue, Apr 17, 2018 at 03:23:33PM -0400, John Ferlan wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1526382

Re: [libvirt] [PATCH 2/2] storage: Check qemu-img encryption type capability

2018-04-18 Thread Daniel P . Berrangé
On Wed, Apr 18, 2018 at 08:08:41AM -0400, John Ferlan wrote: > > > On 04/18/2018 04:29 AM, Daniel P. Berrangé wrote: > > On Tue, Apr 17, 2018 at 03:23:33PM -0400, John Ferlan wrote: > >> https://bugzilla.redhat.com/show_bug.cgi?id=1526382 > >> > >> As of QEMU 2.9, qemu-img has enforced using the

Re: [libvirt] [PATCH 2/2] storage: Check qemu-img encryption type capability

2018-04-18 Thread John Ferlan
On 04/18/2018 04:29 AM, Daniel P. Berrangé wrote: > On Tue, Apr 17, 2018 at 03:23:33PM -0400, John Ferlan wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=1526382 >> >> As of QEMU 2.9, qemu-img has enforced using the "key-secret" for >> creation of encrypted volumes. That is, LUKS

Re: [libvirt] [PATCH 2/2] storage: Check qemu-img encryption type capability

2018-04-18 Thread Daniel P . Berrangé
On Tue, Apr 17, 2018 at 03:23:33PM -0400, John Ferlan wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1526382 > > As of QEMU 2.9, qemu-img has enforced using the "key-secret" for > creation of encrypted volumes. That is, LUKS encryption is now > required and the old (awful) qcow[2]

Re: [libvirt] [PATCH 2/2] storage: Check qemu-img encryption type capability

2018-04-17 Thread John Ferlan
On 04/17/2018 04:47 PM, Ján Tomko wrote: > On Tue, Apr 17, 2018 at 03:23:33PM -0400, John Ferlan wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=1526382 >> >> As of QEMU 2.9, qemu-img has enforced using the "key-secret" for >> creation of encrypted volumes. That is, LUKS encryption is now

Re: [libvirt] [PATCH 2/2] storage: Check qemu-img encryption type capability

2018-04-17 Thread Ján Tomko
On Tue, Apr 17, 2018 at 03:23:33PM -0400, John Ferlan wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1526382 As of QEMU 2.9, qemu-img has enforced using the "key-secret" for creation of encrypted volumes. That is, LUKS encryption is now required and the old (awful) qcow[2] encryption

[libvirt] [PATCH 2/2] storage: Check qemu-img encryption type capability

2018-04-17 Thread John Ferlan
https://bugzilla.redhat.com/show_bug.cgi?id=1526382 As of QEMU 2.9, qemu-img has enforced using the "key-secret" for creation of encrypted volumes. That is, LUKS encryption is now required and the old (awful) qcow[2] encryption methodolgy is no longer supported. In order to check for this, we