Re: [libvirt] [PATCH 2/2] test_driver: implement virDomainSetBlockIoTune

2019-08-08 Thread Erik Skultety
On Wed, Aug 07, 2019 at 12:52:17PM +0200, Ilias Stamatis wrote: > On Sun, Aug 4, 2019 at 6:32 PM Erik Skultety wrote: > > > > On Sat, Jul 27, 2019 at 05:04:38PM +0200, Ilias Stamatis wrote: > > > Signed-off-by: Ilias Stamatis > > > --- > > > > > > I deliberately omitted the logic from

Re: [libvirt] [PATCH 2/2] test_driver: implement virDomainSetBlockIoTune

2019-08-07 Thread Ilias Stamatis
On Sun, Aug 4, 2019 at 6:32 PM Erik Skultety wrote: > > On Sat, Jul 27, 2019 at 05:04:38PM +0200, Ilias Stamatis wrote: > > Signed-off-by: Ilias Stamatis > > --- > > > > I deliberately omitted the logic from qemuDomainSetBlockIoTuneDefaults > > in order to leave the function simpler. I think

Re: [libvirt] [PATCH 2/2] test_driver: implement virDomainSetBlockIoTune

2019-08-04 Thread Erik Skultety
On Sat, Jul 27, 2019 at 05:04:38PM +0200, Ilias Stamatis wrote: > Signed-off-by: Ilias Stamatis > --- > > I deliberately omitted the logic from qemuDomainSetBlockIoTuneDefaults > in order to leave the function simpler. I think that in the case of the > test driver it is ok. > > After all, how we

[libvirt] [PATCH 2/2] test_driver: implement virDomainSetBlockIoTune

2019-07-27 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- I deliberately omitted the logic from qemuDomainSetBlockIoTuneDefaults in order to leave the function simpler. I think that in the case of the test driver it is ok. After all, how we handle the parameters it is supposed to be hypervisor-specific.