Re: [libvirt] [PATCH 2/2] virsh: kill over-engineered asprintf failure recovery

2014-02-24 Thread Michal Privoznik
On 21.02.2014 23:59, Eric Blake wrote: I noticed this while shortning switch statements via VIR_ENUM. Basically, the only ways virAsprintf can fail are if we pass a bogus format string (but we're not THAT bad) or if we run out of memory (but it already warns on our behalf in that case). Throw

Re: [libvirt] [PATCH 2/2] virsh: kill over-engineered asprintf failure recovery

2014-02-24 Thread Eric Blake
On 02/24/2014 10:42 AM, Michal Privoznik wrote: On 21.02.2014 23:59, Eric Blake wrote: I noticed this while shortning switch statements via VIR_ENUM. Basically, the only ways virAsprintf can fail are if we pass a bogus format string (but we're not THAT bad) or if we run out of memory (but it

[libvirt] [PATCH 2/2] virsh: kill over-engineered asprintf failure recovery

2014-02-21 Thread Eric Blake
I noticed this while shortning switch statements via VIR_ENUM. Basically, the only ways virAsprintf can fail are if we pass a bogus format string (but we're not THAT bad) or if we run out of memory (but it already warns on our behalf in that case). Throw away the cruft that tries too hard to