Re: [libvirt] [PATCH 2/2] virutil: fix virGetSCSIHostNumber stub return type

2014-10-30 Thread Roman Bogorodskiy 
  John Ferlan wrote:

 On 10/29/2014 02:20 PM, Roman Bogorodskiy wrote:
  The virGetSCSIHostNumber function return type is int, however
  its stubbed version returns NULL. That results in a build fail
  on systems that uses the stubbed version. Fix by using a proper
  return type.
  ---
   src/util/virutil.c | 2 +-
   1 file changed, 1 insertion(+), 1 deletion(-)
  
 
 ACK - (me who once again gets bit by cut-n-paste of functions)

Pushed, thanks!

Roman Bogorodskiy

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 2/2] virutil: fix virGetSCSIHostNumber stub return type

2014-10-29 Thread Roman Bogorodskiy 
The virGetSCSIHostNumber function return type is int, however
its stubbed version returns NULL. That results in a build fail
on systems that uses the stubbed version. Fix by using a proper
return type.
---
 src/util/virutil.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/util/virutil.c b/src/util/virutil.c
index 3e7f7a2..1116fda 100644
--- a/src/util/virutil.c
+++ b/src/util/virutil.c
@@ -2298,7 +2298,7 @@ virGetSCSIHostNumber(const char *adapter_name 
ATTRIBUTE_UNUSED,
  unsigned int *result ATTRIBUTE_UNUSED)
 {
 virReportSystemError(ENOSYS, %s, _(Not supported on this platform));
-return NULL;
+return -1;
 }
 
 char *
-- 
2.0.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 2/2] virutil: fix virGetSCSIHostNumber stub return type

2014-10-29 Thread John Ferlan 

[I realized I only sent this directly Roman - so I'll put it on list too]


On 10/29/2014 02:20 PM, Roman Bogorodskiy wrote:
 The virGetSCSIHostNumber function return type is int, however
 its stubbed version returns NULL. That results in a build fail
 on systems that uses the stubbed version. Fix by using a proper
 return type.
 ---
  src/util/virutil.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
 

ACK - (me who once again gets bit by cut-n-paste of functions)

John

 diff --git a/src/util/virutil.c b/src/util/virutil.c
 index 3e7f7a2..1116fda 100644
 --- a/src/util/virutil.c
 +++ b/src/util/virutil.c
 @@ -2298,7 +2298,7 @@ virGetSCSIHostNumber(const char *adapter_name 
 ATTRIBUTE_UNUSED,
   unsigned int *result ATTRIBUTE_UNUSED)
  {
  virReportSystemError(ENOSYS, %s, _(Not supported on this platform));
 -return NULL;
 +return -1;
  }
  
  char *
 

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list