Re: [libvirt] [PATCH 2/3] Remove dead code in qemuDomainAssignPCIAddresses

2015-01-16 Thread Ján Tomko
On 01/15/2015 02:14 PM, Erik Skultety wrote: > We tested for positive return value from virDomainMaybeAddController, > but it returns 0 or -1 only resulting in a dead code. > --- If it returns < 0, we've already jumped to cleanup, thus the condition is always true here. The proper fix would be to

Re: [libvirt] [PATCH 2/3] Remove dead code in qemuDomainAssignPCIAddresses

2015-01-16 Thread Michal Privoznik
On 15.01.2015 14:14, Erik Skultety wrote: > We tested for positive return value from virDomainMaybeAddController, > but it returns 0 or -1 only resulting in a dead code. > --- > src/qemu/qemu_command.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/qemu/qemu_command.

[libvirt] [PATCH 2/3] Remove dead code in qemuDomainAssignPCIAddresses

2015-01-15 Thread Erik Skultety
We tested for positive return value from virDomainMaybeAddController, but it returns 0 or -1 only resulting in a dead code. --- src/qemu/qemu_command.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 06def5f..1671e11 10064