Re: [libvirt] [PATCH 2/4] virt-admin: Tweak command parsing logic so that aliases point to new commands

2016-09-13 Thread Michal Privoznik
On 13.09.2016 16:11, Erik Skultety wrote: > On 13/09/16 14:30, Michal Privoznik wrote: >> On 12.09.2016 10:20, Erik Skultety wrote: >>> Change the logic in a way, so that VSH_CMD_FLAG_ALIAS behaves similarly to >>> how VSH_OT_ALIAS for command options, i.e. there is no need for code >>>

Re: [libvirt] [PATCH 2/4] virt-admin: Tweak command parsing logic so that aliases point to new commands

2016-09-13 Thread Erik Skultety
On 13/09/16 14:30, Michal Privoznik wrote: > On 12.09.2016 10:20, Erik Skultety wrote: >> Change the logic in a way, so that VSH_CMD_FLAG_ALIAS behaves similarly to >> how VSH_OT_ALIAS for command options, i.e. there is no need for code >> duplication >> for the alias and the aliased command

Re: [libvirt] [PATCH 2/4] virt-admin: Tweak command parsing logic so that aliases point to new commands

2016-09-13 Thread Michal Privoznik
On 12.09.2016 10:20, Erik Skultety wrote: > Change the logic in a way, so that VSH_CMD_FLAG_ALIAS behaves similarly to > how VSH_OT_ALIAS for command options, i.e. there is no need for code > duplication > for the alias and the aliased command structures. Along with that change, > switch any

[libvirt] [PATCH 2/4] virt-admin: Tweak command parsing logic so that aliases point to new commands

2016-09-12 Thread Erik Skultety
Change the logic in a way, so that VSH_CMD_FLAG_ALIAS behaves similarly to how VSH_OT_ALIAS for command options, i.e. there is no need for code duplication for the alias and the aliased command structures. Along with that change, switch any existing VSH_CMD_FLAG_ALIAS occurrences to this new