Re: [libvirt] [PATCH 2/6] tpm: Add support for external swtpm TPM emulator

2018-04-09 Thread Stefan Berger
On 04/06/2018 10:54 AM, Daniel P. Berrangé wrote: On Fri, Apr 06, 2018 at 10:49:23AM -0400, Stefan Berger wrote: I would feel better if we just directly killed the process - with this approach if something goes wrong with swtpm it may never respond to this request and stay running. swtpm can

Re: [libvirt] [PATCH 2/6] tpm: Add support for external swtpm TPM emulator

2018-04-06 Thread Daniel P . Berrangé
On Fri, Apr 06, 2018 at 10:49:23AM -0400, Stefan Berger wrote: > On 04/06/2018 10:12 AM, Daniel P. Berrangé wrote: > > On Fri, Apr 06, 2018 at 07:23:49AM -0400, Stefan Berger wrote: > > > On 04/06/2018 04:26 AM, Daniel P. Berrangé wrote: > > > > On Thu, Apr 05, 2018 at 05:56:02PM -0400, Stefan

Re: [libvirt] [PATCH 2/6] tpm: Add support for external swtpm TPM emulator

2018-04-06 Thread Stefan Berger
On 04/06/2018 10:12 AM, Daniel P. Berrangé wrote: On Fri, Apr 06, 2018 at 07:23:49AM -0400, Stefan Berger wrote: On 04/06/2018 04:26 AM, Daniel P. Berrangé wrote: On Thu, Apr 05, 2018 at 05:56:02PM -0400, Stefan Berger wrote: This patch adds support for an external swtpm TPM emulator. The XML

Re: [libvirt] [PATCH 2/6] tpm: Add support for external swtpm TPM emulator

2018-04-06 Thread Daniel P . Berrangé
On Fri, Apr 06, 2018 at 07:23:49AM -0400, Stefan Berger wrote: > On 04/06/2018 04:26 AM, Daniel P. Berrangé wrote: > > On Thu, Apr 05, 2018 at 05:56:02PM -0400, Stefan Berger wrote: > > > This patch adds support for an external swtpm TPM emulator. The XML for > > > this type of TPM looks as

Re: [libvirt] [PATCH 2/6] tpm: Add support for external swtpm TPM emulator

2018-04-06 Thread Stefan Berger
On 04/06/2018 07:23 AM, Stefan Berger wrote: On 04/06/2018 04:26 AM, Daniel P. Berrangé wrote: On Thu, Apr 05, 2018 at 05:56:02PM -0400, Stefan Berger wrote: This patch adds support for an external swtpm TPM emulator. The XML for this type of TPM looks as follows: The XML will

Re: [libvirt] [PATCH 2/6] tpm: Add support for external swtpm TPM emulator

2018-04-06 Thread Stefan Berger
On 04/06/2018 04:26 AM, Daniel P. Berrangé wrote: On Thu, Apr 05, 2018 at 05:56:02PM -0400, Stefan Berger wrote: This patch adds support for an external swtpm TPM emulator. The XML for this type of TPM looks as follows: The XML will currently only start a TPM 1.2. Upon the first

Re: [libvirt] [PATCH 2/6] tpm: Add support for external swtpm TPM emulator

2018-04-06 Thread Daniel P . Berrangé
On Thu, Apr 05, 2018 at 05:56:02PM -0400, Stefan Berger wrote: > This patch adds support for an external swtpm TPM emulator. The XML for > this type of TPM looks as follows: > > > > > > The XML will currently only start a TPM 1.2. > > Upon the first start, libvirt will run

[libvirt] [PATCH 2/6] tpm: Add support for external swtpm TPM emulator

2018-04-05 Thread Stefan Berger
This patch adds support for an external swtpm TPM emulator. The XML for this type of TPM looks as follows: The XML will currently only start a TPM 1.2. Upon the first start, libvirt will run `swtpm_setup`, which will simulate the manufacturing of a TPM and create certificates for it and