Re: [libvirt] [PATCH 25/42] storage: Don't check the output of virGetUserRuntimeDirectory()

2019-12-19 Thread Ján Tomko 

On Thu, Dec 19, 2019 at 11:04:30AM +0100, Fabiano Fidêncio wrote:

virGetUserRuntimeDirectory() *never* *ever* returns NULL, making the
checks for it completely unnecessary.

Signed-off-by: Fabiano Fidêncio 
---
src/storage/storage_driver.c | 2 --
1 file changed, 2 deletions(-)



Reviewed-by: Ján Tomko 

Jano


signature.asc
Description: PGP signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 25/42] storage: Don't check the output of virGetUserRuntimeDirectory()

2019-12-19 Thread Fabiano Fidêncio 
virGetUserRuntimeDirectory() *never* *ever* returns NULL, making the
checks for it completely unnecessary.

Signed-off-by: Fabiano Fidêncio 
---
 src/storage/storage_driver.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c
index 71078dfbd6..a33328db37 100644
--- a/src/storage/storage_driver.c
+++ b/src/storage/storage_driver.c
@@ -278,8 +278,6 @@ storageStateInitialize(bool privileged,
 } else {
 configdir = virGetUserConfigDirectory();
 rundir = virGetUserRuntimeDirectory();
-if (!rundir)
-goto error;
 
 driver->configDir = g_strdup_printf("%s/storage", configdir);
 driver->autostartDir = g_strdup_printf("%s/storage/autostart", 
configdir);
-- 
2.24.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list