Re: [libvirt] [PATCH 3/3] Avoid rare race when undefining domain

2014-10-31 Thread Martin Kletzander
On Thu, Oct 30, 2014 at 05:44:23PM +, Daniel P. Berrange wrote: On Thu, Oct 30, 2014 at 06:39:56PM +0100, Michal Privoznik wrote: On 30.10.2014 16:04, Martin Kletzander wrote: When one domain is being undefined and at the same time started, for example, there is a possibility of a rare

Re: [libvirt] [PATCH 3/3] Avoid rare race when undefining domain

2014-10-31 Thread Michal Privoznik
On 31.10.2014 07:35, Martin Kletzander wrote: On Thu, Oct 30, 2014 at 05:44:23PM +, Daniel P. Berrange wrote: On Thu, Oct 30, 2014 at 06:39:56PM +0100, Michal Privoznik wrote: On 30.10.2014 16:04, Martin Kletzander wrote: When one domain is being undefined and at the same time started, for

Re: [libvirt] [PATCH 3/3] Avoid rare race when undefining domain

2014-10-31 Thread Martin Kletzander
On Fri, Oct 31, 2014 at 02:28:49PM +0100, Michal Privoznik wrote: On 31.10.2014 07:35, Martin Kletzander wrote: On Thu, Oct 30, 2014 at 05:44:23PM +, Daniel P. Berrange wrote: On Thu, Oct 30, 2014 at 06:39:56PM +0100, Michal Privoznik wrote: On 30.10.2014 16:04, Martin Kletzander wrote:

[libvirt] [PATCH 3/3] Avoid rare race when undefining domain

2014-10-30 Thread Martin Kletzander
When one domain is being undefined and at the same time started, for example, there is a possibility of a rare problem occuring. - Thread 1 does virDomainUndefine(), has the lock, checks that the domain is active and because it's not, calls virDomainObjListRemove(). - Thread 2 does

Re: [libvirt] [PATCH 3/3] Avoid rare race when undefining domain

2014-10-30 Thread Michal Privoznik
On 30.10.2014 16:04, Martin Kletzander wrote: When one domain is being undefined and at the same time started, for example, there is a possibility of a rare problem occuring. - Thread 1 does virDomainUndefine(), has the lock, checks that the domain is active and because it's not, calls

Re: [libvirt] [PATCH 3/3] Avoid rare race when undefining domain

2014-10-30 Thread Daniel P. Berrange
On Thu, Oct 30, 2014 at 06:39:56PM +0100, Michal Privoznik wrote: On 30.10.2014 16:04, Martin Kletzander wrote: When one domain is being undefined and at the same time started, for example, there is a possibility of a rare problem occuring. - Thread 1 does virDomainUndefine(), has the