Re: [libvirt] [PATCH 3/3] gluster: Fix key attribute for gluster volumes

2014-02-25 Thread Peter Krempa
On 02/24/14 21:59, Eric Blake wrote: On 02/24/2014 08:21 AM, Peter Krempa wrote: According to our documentation the key value has the following meaning: Providing an identifier for the volume which is globally unique. This cannot be set when creating a volume: it is always generated. The

Re: [libvirt] [PATCH 3/3] gluster: Fix key attribute for gluster volumes

2014-02-25 Thread Daniel P. Berrange
On Mon, Feb 24, 2014 at 01:59:30PM -0700, Eric Blake wrote: On 02/24/2014 08:21 AM, Peter Krempa wrote: According to our documentation the key value has the following meaning: Providing an identifier for the volume which is globally unique. This cannot be set when creating a volume: it is

Re: [libvirt] [PATCH 3/3] gluster: Fix key attribute for gluster volumes

2014-02-25 Thread Eric Blake
On 02/25/2014 03:36 AM, Peter Krempa wrote: The problem you are describing here is that two different keys may map to a single volume. The issue I'm trying to solve is that one key may map to two distinct volumes. As a first step we should thus clarify which way the key should be unique.

[libvirt] [PATCH 3/3] gluster: Fix key attribute for gluster volumes

2014-02-24 Thread Peter Krempa
According to our documentation the key value has the following meaning: Providing an identifier for the volume which is globally unique. This cannot be set when creating a volume: it is always generated. The currently used keys for gluster volumes consist of the gluster volume name and file path.

Re: [libvirt] [PATCH 3/3] gluster: Fix key attribute for gluster volumes

2014-02-24 Thread Eric Blake
On 02/24/2014 08:21 AM, Peter Krempa wrote: According to our documentation the key value has the following meaning: Providing an identifier for the volume which is globally unique. This cannot be set when creating a volume: it is always generated. The currently used keys for gluster volumes