Re: [libvirt] [PATCH 3/3] storage: Fix checking whether source filesystem is mounted

2017-02-10 Thread Erik Skultety
On Thu, Feb 09, 2017 at 06:05:41PM -0500, John Ferlan wrote: > > > On 02/07/2017 09:16 AM, Erik Skultety wrote: > > Right now, we use simple string comparison both on the source paths > > (mount's output vs pool's source) and the target (mount's mnt_dir vs > > pool's target). The problem are

Re: [libvirt] [PATCH 3/3] storage: Fix checking whether source filesystem is mounted

2017-02-09 Thread John Ferlan
On 02/07/2017 09:16 AM, Erik Skultety wrote: > Right now, we use simple string comparison both on the source paths > (mount's output vs pool's source) and the target (mount's mnt_dir vs > pool's target). The problem are symlinks and mount indeed returns > symlinks in its output, e.g.

[libvirt] [PATCH 3/3] storage: Fix checking whether source filesystem is mounted

2017-02-07 Thread Erik Skultety
Right now, we use simple string comparison both on the source paths (mount's output vs pool's source) and the target (mount's mnt_dir vs pool's target). The problem are symlinks and mount indeed returns symlinks in its output, e.g. /dev/mappper/lvm_symlink. The same goes for the pool's