Re: [libvirt] [PATCH 3/4] libxl: MigratePrepare: properly cleanup after virDomainObjListAdd

2018-03-16 Thread Jim Fehlig
On 03/14/2018 07:19 AM, John Ferlan wrote: On 03/13/2018 01:26 PM, Jim Fehlig wrote: libxlDomainMigrationPrepare adds the incoming domain def to the list of domains via virDomainObjListAdd, which returns a locked and ref counted virDomainObj. On exit the object is unlocked but not unref'ed.

Re: [libvirt] [PATCH 3/4] libxl: MigratePrepare: properly cleanup after virDomainObjListAdd

2018-03-15 Thread John Ferlan
On 03/13/2018 01:26 PM, Jim Fehlig wrote: > libxlDomainMigrationPrepare adds the incoming domain def to the list of > domains via virDomainObjListAdd, which returns a locked and ref counted > virDomainObj. On exit the object is unlocked but not unref'ed. The same > is true for

[libvirt] [PATCH 3/4] libxl: MigratePrepare: properly cleanup after virDomainObjListAdd

2018-03-13 Thread Jim Fehlig
libxlDomainMigrationPrepare adds the incoming domain def to the list of domains via virDomainObjListAdd, which returns a locked and ref counted virDomainObj. On exit the object is unlocked but not unref'ed. The same is true for libxlDomainMigrationPrepareTunnel3. Convert both to use the