Re: [libvirt] [PATCH 3/4] tests: Introduce negative versions of DO_TEST_CAPS_LATEST

2018-12-12 Thread Erik Skultety
On Tue, Dec 11, 2018 at 06:51:56PM -0500, John Ferlan wrote: > > > On 12/7/18 9:47 AM, Erik Skultety wrote: > > As commit d8266ebe161 demonstrated, it's so easy to forget to add a > > single capability which in turn can easily fool the test suite so that > > tests expecting a failure can fail with

Re: [libvirt] [PATCH 3/4] tests: Introduce negative versions of DO_TEST_CAPS_LATEST

2018-12-11 Thread John Ferlan
On 12/7/18 9:47 AM, Erik Skultety wrote: > As commit d8266ebe161 demonstrated, it's so easy to forget to add a > single capability which in turn can easily fool the test suite so that > tests expecting a failure can fail with a different error than we > expected, but still making those pass. Unf

[libvirt] [PATCH 3/4] tests: Introduce negative versions of DO_TEST_CAPS_LATEST

2018-12-07 Thread Erik Skultety
As commit d8266ebe161 demonstrated, it's so easy to forget to add a single capability which in turn can easily fool the test suite so that tests expecting a failure can fail with a different error than we expected, but still making those pass. Unfortunately for commit d8266ebe161, it allowed a doma