Re: [libvirt] [PATCH 3/4] travis: test upstart script handling on precise distro scenario

2018-02-27 Thread Andrea Bolognani
On Tue, 2018-02-27 at 15:46 +, Daniel P. Berrangé wrote: > > > Even though RHEL-6 supports upstart, I'm fairly sure we always > > > deployed RHEL-6 using traditional initscripts, not the upstart > > > scripts. > > > > So we have on Ubuntu, apparently. > > While upstream libvirt may be

Re: [libvirt] [PATCH 3/4] travis: test upstart script handling on precise distro scenario

2018-02-27 Thread Daniel P . Berrangé
On Tue, Feb 27, 2018 at 04:43:18PM +0100, Andrea Bolognani wrote: > On Tue, 2018-02-27 at 15:19 +, Daniel P. Berrangé wrote: > > > Both precise and trusty use upstart, so there's no reason not > > > to apply this to both, especially if we're going trusty-only as > > > suggested earlier.

Re: [libvirt] [PATCH 3/4] travis: test upstart script handling on precise distro scenario

2018-02-27 Thread Andrea Bolognani
On Tue, 2018-02-27 at 15:19 +, Daniel P. Berrangé wrote: > > Both precise and trusty use upstart, so there's no reason not > > to apply this to both, especially if we're going trusty-only as > > suggested earlier. Limiting it to the gcc build is rather strange > > as well. > > The initscript

Re: [libvirt] [PATCH 3/4] travis: test upstart script handling on precise distro scenario

2018-02-27 Thread Daniel P . Berrangé
On Tue, Feb 27, 2018 at 03:19:44PM +, Daniel P. Berrangé wrote: > On Tue, Feb 27, 2018 at 04:14:21PM +0100, Andrea Bolognani wrote: > > On Fri, 2018-02-23 at 12:00 +, Daniel P. Berrangé wrote: > > > Signed-off-by: Daniel P. Berrangé > > > --- > > > .travis.yml | 4

Re: [libvirt] [PATCH 3/4] travis: test upstart script handling on precise distro scenario

2018-02-27 Thread Daniel P . Berrangé
On Tue, Feb 27, 2018 at 04:14:21PM +0100, Andrea Bolognani wrote: > On Fri, 2018-02-23 at 12:00 +, Daniel P. Berrangé wrote: > > Signed-off-by: Daniel P. Berrangé > > --- > > .travis.yml | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git

Re: [libvirt] [PATCH 3/4] travis: test upstart script handling on precise distro scenario

2018-02-27 Thread Andrea Bolognani
On Fri, 2018-02-23 at 12:00 +, Daniel P. Berrangé wrote: > Signed-off-by: Daniel P. Berrangé > --- > .travis.yml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/.travis.yml b/.travis.yml > index 41a293451c..0328fcb8f1 100644 > ---

[libvirt] [PATCH 3/4] travis: test upstart script handling on precise distro scenario

2018-02-23 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- .travis.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 41a293451c..0328fcb8f1 100644 --- a/.travis.yml +++ b/.travis.yml @@ -6,6 +6,8 @@ matrix: include: - compiler: gcc