Re: [libvirt] [PATCH 3/4] virCommand: Make virCommandPassFDGetFDIndex fail if passed command is in error state

2019-05-14 Thread Daniel P . Berrangé
On Tue, May 14, 2019 at 11:24:11AM +0200, Michal Privoznik wrote: > The idea of virCommand* APIs is that a possible error that > occurred while constructing cmd line is kept in virCommand > struct. If that's the case all subsequent calls to virCommand*() > are NO-OPs or they return an error. Well,

Re: [libvirt] [PATCH 3/4] virCommand: Make virCommandPassFDGetFDIndex fail if passed command is in error state

2019-05-14 Thread Erik Skultety
On Tue, May 14, 2019 at 11:24:11AM +0200, Michal Privoznik wrote: > The idea of virCommand* APIs is that a possible error that > occurred while constructing cmd line is kept in virCommand > struct. If that's the case all subsequent calls to virCommand*() > are NO-OPs or they return an error. Well,

[libvirt] [PATCH 3/4] virCommand: Make virCommandPassFDGetFDIndex fail if passed command is in error state

2019-05-14 Thread Michal Privoznik
The idea of virCommand* APIs is that a possible error that occurred while constructing cmd line is kept in virCommand struct. If that's the case all subsequent calls to virCommand*() are NO-OPs or they return an error. Well, virCommandPassFDGetFDIndex() is not honoring that. Signed-off-by: Michal