Re: [libvirt] [PATCH 3/4] vol-info: Check for NFS FS type

2014-08-11 Thread Ján Tomko
On 08/09/2014 12:28 AM, John Ferlan wrote: Testing seems to indicate that posix_fallocate() either doesn't work as expected on the target or using the target.path is incorrect... Before posix_fallocate stat st_blocks=0 st_blksize=1048576 st_size=10485760 lseek end=10485760 posix_fallocate

Re: [libvirt] [PATCH 3/4] vol-info: Check for NFS FS type

2014-08-11 Thread John Ferlan
...snip... Why all this happens I'm not sure. Bug in posix_fallocate()? Bug in configuration? I have to assume that when this code was first added NFS probably was still using smaller block sizes. The code was introduced in 2013. Maybe it wasn't tested on NFS at all? It looks like a

Re: [libvirt] [PATCH 3/4] vol-info: Check for NFS FS type

2014-08-08 Thread Ján Tomko
On 08/05/2014 04:38 PM, John Ferlan wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1077068 Check for the NFS FS type being true for a local stat of the file to force usage of the 'st_size' value rather than calculating the size using the 'st_blocks' and 'st_blksize'. As described in the

Re: [libvirt] [PATCH 3/4] vol-info: Check for NFS FS type

2014-08-08 Thread John Ferlan
On 08/08/2014 07:07 AM, Ján Tomko wrote: On 08/05/2014 04:38 PM, John Ferlan wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1077068 Check for the NFS FS type being true for a local stat of the file to force usage of the 'st_size' value rather than calculating the size using the

Re: [libvirt] [PATCH 3/4] vol-info: Check for NFS FS type

2014-08-08 Thread John Ferlan
On 08/08/2014 07:07 AM, Ján Tomko wrote: On 08/05/2014 04:38 PM, John Ferlan wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1077068 Check for the NFS FS type being true for a local stat of the file to force usage of the 'st_size' value rather than calculating the size using the

Re: [libvirt] [PATCH 3/4] vol-info: Check for NFS FS type

2014-08-08 Thread John Ferlan
On 08/08/2014 11:26 AM, John Ferlan wrote: On 08/08/2014 07:07 AM, Ján Tomko wrote: On 08/05/2014 04:38 PM, John Ferlan wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1077068 Check for the NFS FS type being true for a local stat of the file to force usage of the 'st_size' value

[libvirt] [PATCH 3/4] vol-info: Check for NFS FS type

2014-08-05 Thread John Ferlan
https://bugzilla.redhat.com/show_bug.cgi?id=1077068 Check for the NFS FS type being true for a local stat of the file to force usage of the 'st_size' value rather than calculating the size using the 'st_blocks' and 'st_blksize'. As described in the stat(2) man page: Use of the st_blocks and