Re: [libvirt] [PATCH 3/6] conf: Make switch statements more strict

2017-02-22 Thread Andrea Bolognani
On Wed, 2017-02-22 at 09:40 -0500, Laine Stump wrote: [...] > >   virReportError(VIR_ERR_INTERNAL_ERROR, > > -   _("Invalid PCI controller model %d"), model); > > +   _("PCI controller model was not set correctly")); >  > You're going to need to

Re: [libvirt] [PATCH 3/6] conf: Make switch statements more strict

2017-02-22 Thread Laine Stump
On 02/21/2017 02:57 PM, Andrea Bolognani wrote: When switching over the values in the virDomainControllerModelPCI enumeration, make sure the proper cast is in place so that the compiler can warn us when the coverage is not exaustive. For the same reason, remove the 'default' case from one of

[libvirt] [PATCH 3/6] conf: Make switch statements more strict

2017-02-21 Thread Andrea Bolognani
When switching over the values in the virDomainControllerModelPCI enumeration, make sure the proper cast is in place so that the compiler can warn us when the coverage is not exaustive. For the same reason, remove the 'default' case from one of the existing switch statements. ---