Re: [libvirt] [PATCH 3/6] util: storagefile: Don't report errors from virStorageSourceUpdatePhysicalSize

2019-08-15 Thread Ján Tomko 

On Wed, Aug 14, 2019 at 06:59:18PM +0200, Peter Krempa wrote:

virStorageSourceUpdatePhysicalSize is called only from
qemuDomainStorageUpdatePhysical and all callers of it reset the libvirt
error if -1 is returned.

Don't bother setting the error in the first place.

Signed-off-by: Peter Krempa 
---
src/util/virstoragefile.c | 12 ++--
1 file changed, 2 insertions(+), 10 deletions(-)



Reviewed-by: Ján Tomko 

Jano


signature.asc
Description: PGP signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 3/6] util: storagefile: Don't report errors from virStorageSourceUpdatePhysicalSize

2019-08-14 Thread Peter Krempa 
virStorageSourceUpdatePhysicalSize is called only from
qemuDomainStorageUpdatePhysical and all callers of it reset the libvirt
error if -1 is returned.

Don't bother setting the error in the first place.

Signed-off-by: Peter Krempa 
---
 src/util/virstoragefile.c | 12 ++--
 1 file changed, 2 insertions(+), 10 deletions(-)

diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c
index 4011187a7e..21bd1f00c9 100644
--- a/src/util/virstoragefile.c
+++ b/src/util/virstoragefile.c
@@ -3746,7 +3746,7 @@ virStorageSourceNewFromBacking(virStorageSourcePtr parent)
  * To be called for domain storage source reporting as the volume code does
  * not set/use the 'type' field for the voldef->source.target
  *
- * Returns 0 on success, -1 on error.
+ * Returns 0 on success, -1 on error. No libvirt errors are reported.
  */
 int
 virStorageSourceUpdatePhysicalSize(virStorageSourcePtr src,
@@ -3763,11 +3763,8 @@ virStorageSourceUpdatePhysicalSize(virStorageSourcePtr 
src,
 break;

 case VIR_STORAGE_TYPE_BLOCK:
-if ((end = lseek(fd, 0, SEEK_END)) == (off_t) -1) {
-virReportSystemError(errno, _("failed to seek to end of '%s'"),
- src->path);
+if ((end = lseek(fd, 0, SEEK_END)) == (off_t) -1)
 return -1;
-}

 src->physical = end;
 break;
@@ -3780,12 +3777,7 @@ virStorageSourceUpdatePhysicalSize(virStorageSourcePtr 
src,
 case VIR_STORAGE_TYPE_VOLUME:
 case VIR_STORAGE_TYPE_NONE:
 case VIR_STORAGE_TYPE_LAST:
-virReportError(VIR_ERR_INTERNAL_ERROR,
-   _("cannot retrieve physical for path '%s' type '%s'"),
-   NULLSTR(src->path),
-   virStorageTypeToString(actual_type));
 return -1;
-break;
 }

 return 0;
-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list