Re: [libvirt] [PATCH for v4.6.0] cgroups: Don't leave stale pointers around after virCgroupFree

2018-07-30 Thread Daniel P . Berrangé
On Mon, Jul 30, 2018 at 12:47:37PM +0200, Erik Skultety wrote: > On Mon, Jul 30, 2018 at 11:35:02AM +0100, Daniel P. Berrangé wrote: > > On Mon, Jul 30, 2018 at 12:30:09PM +0200, Pavel Hrdina wrote: > > > On Mon, Jul 30, 2018 at 09:58:41AM +0100, Daniel P. Berrangé wrote: > > > > On Mon, Jul 30,

Re: [libvirt] [PATCH for v4.6.0] cgroups: Don't leave stale pointers around after virCgroupFree

2018-07-30 Thread Erik Skultety
On Mon, Jul 30, 2018 at 11:35:02AM +0100, Daniel P. Berrangé wrote: > On Mon, Jul 30, 2018 at 12:30:09PM +0200, Pavel Hrdina wrote: > > On Mon, Jul 30, 2018 at 09:58:41AM +0100, Daniel P. Berrangé wrote: > > > On Mon, Jul 30, 2018 at 09:48:51AM +0100, Daniel P. Berrangé wrote: > > > > On Mon, Jul

Re: [libvirt] [PATCH for v4.6.0] cgroups: Don't leave stale pointers around after virCgroupFree

2018-07-30 Thread Daniel P . Berrangé
On Mon, Jul 30, 2018 at 12:30:09PM +0200, Pavel Hrdina wrote: > On Mon, Jul 30, 2018 at 09:58:41AM +0100, Daniel P. Berrangé wrote: > > On Mon, Jul 30, 2018 at 09:48:51AM +0100, Daniel P. Berrangé wrote: > > > On Mon, Jul 30, 2018 at 10:25:05AM +0200, Michal Privoznik wrote: > > > > One of the

Re: [libvirt] [PATCH for v4.6.0] cgroups: Don't leave stale pointers around after virCgroupFree

2018-07-30 Thread Pavel Hrdina
On Mon, Jul 30, 2018 at 09:58:41AM +0100, Daniel P. Berrangé wrote: > On Mon, Jul 30, 2018 at 09:48:51AM +0100, Daniel P. Berrangé wrote: > > On Mon, Jul 30, 2018 at 10:25:05AM +0200, Michal Privoznik wrote: > > > One of the attributes that original virCgroupFree() had was it > > > set passed

Re: [libvirt] [PATCH for v4.6.0] cgroups: Don't leave stale pointers around after virCgroupFree

2018-07-30 Thread Daniel P . Berrangé
On Mon, Jul 30, 2018 at 09:48:51AM +0100, Daniel P. Berrangé wrote: > On Mon, Jul 30, 2018 at 10:25:05AM +0200, Michal Privoznik wrote: > > One of the attributes that original virCgroupFree() had was it > > set passed pointer to NULL. For instance in the following code > > the latter call would be

Re: [libvirt] [PATCH for v4.6.0] cgroups: Don't leave stale pointers around after virCgroupFree

2018-07-30 Thread Daniel P . Berrangé
On Mon, Jul 30, 2018 at 10:25:05AM +0200, Michal Privoznik wrote: > One of the attributes that original virCgroupFree() had was it > set passed pointer to NULL. For instance in the following code > the latter call would be practically a no-op: > > virCgroupFree(); > virCgroupFree(); > >

[libvirt] [PATCH for v4.6.0] cgroups: Don't leave stale pointers around after virCgroupFree

2018-07-30 Thread Michal Privoznik
One of the attributes that original virCgroupFree() had was it set passed pointer to NULL. For instance in the following code the latter call would be practically a no-op: virCgroupFree(); virCgroupFree(); However, this behaviour of the function was changed in 0f80c71822d824 but