Re: [libvirt] [PATCH for v4.6.0 0/2] Fix some random problems

2018-08-05 Thread Daniel P . Berrangé
On Wed, Aug 01, 2018 at 02:57:07PM +0200, Bjoern Walk wrote: > And here's the fix for the viriscsitest on big-endian machine like > Daniel suggested. > > Bjoern > > -- > IBM Systems > Linux on Z & Virtualization Development >

Re: [libvirt] [PATCH for v4.6.0 0/2] Fix some random problems

2018-08-05 Thread Bjoern Walk
Pino Toscano [2018-08-01, 03:21PM +0200]: > Hi Bjoern, > > On Wednesday, 1 August 2018 14:57:07 CEST Bjoern Walk wrote: > > And here's the fix for the viriscsitest on big-endian machine like > > Daniel suggested. > > I sent an alternative fix, only for viriscsitest, while you sent this > patch.

Re: [libvirt] [PATCH for v4.6.0 0/2] Fix some random problems

2018-08-05 Thread Pino Toscano
Hi Bjoern, On Wednesday, 1 August 2018 14:57:07 CEST Bjoern Walk wrote: > And here's the fix for the viriscsitest on big-endian machine like > Daniel suggested. I sent an alternative fix, only for viriscsitest, while you sent this patch. IMHO virRandomBits() ought to not deal with endianness,

Re: [libvirt] [PATCH for v4.6.0 0/2] Fix some random problems

2018-08-05 Thread Pino Toscano
On Wednesday, 1 August 2018 13:44:31 CEST Michal Privoznik wrote: > Bad pun. But while debugging the issue Bjoern raised [1] I've noticed > these problems. > > https://www.redhat.com/archives/libvir-list/2018-July/msg02101.html > > Michal Prívozník (2): > util: Don't overflow in virRandomBits

Re: [libvirt] [PATCH for v4.6.0 0/2] Fix some random problems

2018-08-02 Thread Bjoern Walk
Eric Blake [2018-08-01, 09:51AM -0500]: > On 08/01/2018 07:57 AM, Bjoern Walk wrote: > > And here's the fix for the viriscsitest on big-endian machine like > > Daniel suggested. > > > From d59b254294a90c5a9ca0fb6ad29465cd0950bb61 Mon Sep 17 00:00:00 2001 > > From: Bjoern Walk > > Date: Wed, 1

Re: [libvirt] [PATCH for v4.6.0 0/2] Fix some random problems

2018-08-01 Thread Eric Blake
On 08/01/2018 07:57 AM, Bjoern Walk wrote: And here's the fix for the viriscsitest on big-endian machine like Daniel suggested. From d59b254294a90c5a9ca0fb6ad29465cd0950bb61 Mon Sep 17 00:00:00 2001 From: Bjoern Walk Date: Wed, 1 Aug 2018 14:48:47 +0200 Subject: [PATCH] util: virrandom: make

Re: [libvirt] [PATCH for v4.6.0 0/2] Fix some random problems

2018-08-01 Thread Bjoern Walk
And here's the fix for the viriscsitest on big-endian machine like Daniel suggested. Bjoern -- IBM Systems Linux on Z & Virtualization Development IBM Deutschland Research & Development GmbH Schönaicher Str. 220, 71032

[libvirt] [PATCH for v4.6.0 0/2] Fix some random problems

2018-08-01 Thread Michal Privoznik
Bad pun. But while debugging the issue Bjoern raised [1] I've noticed these problems. https://www.redhat.com/archives/libvir-list/2018-July/msg02101.html Michal Prívozník (2): util: Don't overflow in virRandomBits viriscsi: Request more random bits for interface name src/util/viriscsi.c |