[libvirt] [PATCH glib] gobject-stream: fix issue found by coverity

2014-02-20 Thread Pavel Hrdina
The coverity server found issue in gvir_stream_close function that we ignore return values of g_input_stream_close and g_outpu_stream_close, but we also ignore the error message and we assume that it's closed without error. Now we will check return values and also propagate the error message to

Re: [libvirt] [PATCH glib] gobject-stream: fix issue found by coverity

2014-02-20 Thread Christophe Fergeau
Hey, On Thu, Feb 20, 2014 at 01:49:31PM +0100, Pavel Hrdina wrote: The coverity server found issue in gvir_stream_close function that we ignore return values of g_input_stream_close and g_outpu_stream_close, but we also ignore the error message and we missing 't' in g_output_stream_close

Re: [libvirt] [PATCH glib] gobject-stream: fix issue found by coverity

2014-02-20 Thread Pavel Hrdina
On 20.2.2014 15:07, Christophe Fergeau wrote: Hey, On Thu, Feb 20, 2014 at 01:49:31PM +0100, Pavel Hrdina wrote: The coverity server found issue in gvir_stream_close function that we ignore return values of g_input_stream_close and g_outpu_stream_close, but we also ignore the error message and

Re: [libvirt] [PATCH glib] gobject-stream: fix issue found by coverity

2014-02-20 Thread Christophe Fergeau
On Thu, Feb 20, 2014 at 03:57:00PM +0100, Pavel Hrdina wrote: On 20.2.2014 15:07, Christophe Fergeau wrote: @@ -102,17 +102,33 @@ static GOutputStream* gvir_stream_get_output_stream(GIOStream *io_stream) static gboolean gvir_stream_close(GIOStream *io_stream,