Re: [libvirt] [PATCH hooks 1/1] Add check for Signed-off-by in commit messages

On Thu, Jan 25, 2018 at 11:13:40AM +0100, Peter Krempa wrote: > On Mon, Jan 22, 2018 at 13:57:07 +, Daniel Berrange wrote: > > On Mon, Jan 22, 2018 at 02:20:52PM +0100, Peter Krempa wrote: > > > On Mon, Jan 22, 2018 at 13:06:28 +, Daniel Berrange wrote: > > > > On Mon, Jan 22, 2018 at

Re: [libvirt] [PATCH hooks 1/1] Add check for Signed-off-by in commit messages

On Mon, Jan 22, 2018 at 13:57:07 +, Daniel Berrange wrote: > On Mon, Jan 22, 2018 at 02:20:52PM +0100, Peter Krempa wrote: > > On Mon, Jan 22, 2018 at 13:06:28 +, Daniel Berrange wrote: > > > On Mon, Jan 22, 2018 at 01:20:12PM +0100, Peter Krempa wrote: > > > > On Mon, Jan 22, 2018 at

Re: [libvirt] [PATCH hooks 1/1] Add check for Signed-off-by in commit messages

On Mon, Jan 22, 2018 at 12:05:19PM +, Daniel P. Berrange wrote: > This extends the update hook so that it enforces a requirement to have a > Signed-off-by line in every commit message. This can be optionally > turned off in individual repos by setting the "hooks.allowmissingsob" > git config

Re: [libvirt] [PATCH hooks 1/1] Add check for Signed-off-by in commit messages

On Mon, Jan 22, 2018 at 08:58:52AM -0500, John Ferlan wrote: > It's also easier than the : > > Reviewed-by: John Ferlan > > line that I keep in a "cheats" file that I always have open so that I > don't have to add it for patches I review. Of course, I could also just > say

Re: [libvirt] [PATCH hooks 1/1] Add check for Signed-off-by in commit messages

On Mon, Jan 22, 2018 at 08:58:52AM -0500, John Ferlan wrote: > > > On 01/22/2018 07:05 AM, Daniel P. Berrange wrote: > > This extends the update hook so that it enforces a requirement to have a > > Signed-off-by line in every commit message. This can be optionally > > turned off in individual

Re: [libvirt] [PATCH hooks 1/1] Add check for Signed-off-by in commit messages

On 01/22/2018 02:20 PM, Peter Krempa wrote: > On Mon, Jan 22, 2018 at 13:06:28 +, Daniel Berrange wrote: >> On Mon, Jan 22, 2018 at 01:20:12PM +0100, Peter Krempa wrote: >>> On Mon, Jan 22, 2018 at 12:05:19 +, Daniel Berrange wrote: This extends the update hook so that it enforces a

Re: [libvirt] [PATCH hooks 1/1] Add check for Signed-off-by in commit messages

On 01/22/2018 07:05 AM, Daniel P. Berrange wrote: > This extends the update hook so that it enforces a requirement to have a > Signed-off-by line in every commit message. This can be optionally > turned off in individual repos by setting the "hooks.allowmissingsob" > git config variable. > >

Re: [libvirt] [PATCH hooks 1/1] Add check for Signed-off-by in commit messages

On Mon, Jan 22, 2018 at 02:20:52PM +0100, Peter Krempa wrote: > On Mon, Jan 22, 2018 at 13:06:28 +, Daniel Berrange wrote: > > On Mon, Jan 22, 2018 at 01:20:12PM +0100, Peter Krempa wrote: > > > On Mon, Jan 22, 2018 at 12:05:19 +, Daniel Berrange wrote: > > > > This extends the update hook

Re: [libvirt] [PATCH hooks 1/1] Add check for Signed-off-by in commit messages

On Mon, Jan 22, 2018 at 02:24:40PM +0100, Ján Tomko wrote: > On Mon, Jan 22, 2018 at 12:42:47PM +, Daniel P. Berrange wrote: > > On Mon, Jan 22, 2018 at 01:22:01PM +0100, Ján Tomko wrote: > > > On Mon, Jan 22, 2018 at 12:05:19PM +, Daniel P. Berrange wrote: > > > > This extends the update

Re: [libvirt] [PATCH hooks 1/1] Add check for Signed-off-by in commit messages

On Mon, Jan 22, 2018 at 12:42:47PM +, Daniel P. Berrange wrote: On Mon, Jan 22, 2018 at 01:22:01PM +0100, Ján Tomko wrote: On Mon, Jan 22, 2018 at 12:05:19PM +, Daniel P. Berrange wrote: > This extends the update hook so that it enforces a requirement to have a > Signed-off-by line in

Re: [libvirt] [PATCH hooks 1/1] Add check for Signed-off-by in commit messages

On Mon, Jan 22, 2018 at 13:06:28 +, Daniel Berrange wrote: > On Mon, Jan 22, 2018 at 01:20:12PM +0100, Peter Krempa wrote: > > On Mon, Jan 22, 2018 at 12:05:19 +, Daniel Berrange wrote: > > > This extends the update hook so that it enforces a requirement to have a > > > Signed-off-by line

Re: [libvirt] [PATCH hooks 1/1] Add check for Signed-off-by in commit messages

On Mon, Jan 22, 2018 at 01:20:12PM +0100, Peter Krempa wrote: > On Mon, Jan 22, 2018 at 12:05:19 +, Daniel Berrange wrote: > > This extends the update hook so that it enforces a requirement to have a > > Signed-off-by line in every commit message. This can be optionally > > turned off in

Re: [libvirt] [PATCH hooks 1/1] Add check for Signed-off-by in commit messages

On Mon, Jan 22, 2018 at 01:22:01PM +0100, Ján Tomko wrote: > On Mon, Jan 22, 2018 at 12:05:19PM +, Daniel P. Berrange wrote: > > This extends the update hook so that it enforces a requirement to have a > > Signed-off-by line in every commit message. This can be optionally > > turned off in

Re: [libvirt] [PATCH hooks 1/1] Add check for Signed-off-by in commit messages

On Mon, Jan 22, 2018 at 12:05:19PM +, Daniel P. Berrange wrote: This extends the update hook so that it enforces a requirement to have a Signed-off-by line in every commit message. This can be optionally turned off in individual repos by setting the "hooks.allowmissingsob" git config

Re: [libvirt] [PATCH hooks 1/1] Add check for Signed-off-by in commit messages

On Mon, Jan 22, 2018 at 12:05:19 +, Daniel Berrange wrote: > This extends the update hook so that it enforces a requirement to have a > Signed-off-by line in every commit message. This can be optionally > turned off in individual repos by setting the "hooks.allowmissingsob" > git config

[libvirt] [PATCH hooks 1/1] Add check for Signed-off-by in commit messages

This extends the update hook so that it enforces a requirement to have a Signed-off-by line in every commit message. This can be optionally turned off in individual repos by setting the "hooks.allowmissingsob" git config variable. Signed-off-by: Daniel P. Berrange ---