Re: [libvirt] [PATCH libvirt-glib 1/3] Add GVirDomainDevice abstract class

2011-11-14 Thread Christophe Fergeau
Hey, On Thu, Nov 10, 2011 at 04:10:32PM -0500, Marc-André Lureau wrote: - Mensaje original - +G_GNUC_INTERNAL +virDomainPtr gvir_domain_device_get_domain_handle(GVirDomainDevice *self) G_GNUC_INTERNAL isn't needed here since it's the default setting for symbols not listed

[libvirt] [PATCH libvirt-glib 1/3] Add GVirDomainDevice abstract class

2011-11-10 Thread Marc-André Lureau
--- libvirt-gobject/Makefile.am|3 + .../libvirt-gobject-domain-device-private.h| 31 + libvirt-gobject/libvirt-gobject-domain-device.c| 139 libvirt-gobject/libvirt-gobject-domain-device.h| 64 +

Re: [libvirt] [PATCH libvirt-glib 1/3] Add GVirDomainDevice abstract class

2011-11-10 Thread Christophe Fergeau
Hey, a few preliminary comments, On Thu, Nov 10, 2011 at 09:33:41PM +0100, Marc-André Lureau wrote: + +G_GNUC_INTERNAL +virDomainPtr gvir_domain_device_get_domain_handle(GVirDomainDevice *self) G_GNUC_INTERNAL isn't needed here since it's the default setting for symbols not listed in the .sym

Re: [libvirt] [PATCH libvirt-glib 1/3] Add GVirDomainDevice abstract class

2011-11-10 Thread Marc-André Lureau
Hi - Mensaje original - +G_GNUC_INTERNAL +virDomainPtr gvir_domain_device_get_domain_handle(GVirDomainDevice *self) G_GNUC_INTERNAL isn't needed here since it's the default setting for symbols not listed in the .sym file. I think it's better to be explicit about it. It's a