On Thu, Nov 10, 2011 at 04:15:01PM -0500, Marc-André Lureau wrote:
On Thu, Nov 10, 2011 at 09:33:42PM +0100, Marc-André Lureau wrote:
Do we really need to use GSlice here? I consider GSlice as something
to use
when you want to make many allocations of same-size objects, will we
allocate
Hey,
A few more comments I made on IRC (no access to this email when I reviewed
the patches), sending them here to be sure they are not missed/lost. The
same comments apply to patch 3/3.
Can you resend the 3 patches with the various issues fixed? then I'll ACK
them.
Christophe
On Thu, Nov 10,
---
libvirt-gobject/Makefile.am|2 +
libvirt-gobject/libvirt-gobject-domain-interface.c | 213
libvirt-gobject/libvirt-gobject-domain-interface.h | 81
libvirt-gobject/libvirt-gobject.h |1 +
A few preliminary remark below, they apply to the next patch as well.
On Thu, Nov 10, 2011 at 09:33:42PM +0100, Marc-André Lureau wrote:
---
libvirt-gobject/Makefile.am|2 +
libvirt-gobject/libvirt-gobject-domain-interface.c | 213
Hi
On Thu, Nov 10, 2011 at 09:33:42PM +0100, Marc-André Lureau wrote:
+case PROP_PATH:
+if (priv-path)
+g_free(priv-path);
You can safely call g_free on a NULL pointer, this makes the code a
bit
simpler, there are several occurrences of this in the 2 patches.
