Re: [libvirt] [PATCH libvirt v2 4/9] remote: Use domainClientEventCallbacks for remoteReplayConnectionClosedEvent

2018-05-09 Thread John Ferlan
[...] > +callback->program = virObjectRef(remoteProgram); > +/* eventID, callbackID, and legacy are not used */ > +callback->eventID = -1; > +callback->callbackID = -1; > if (virConnectRegisterCloseCallback(priv->conn, >

Re: [libvirt] [PATCH libvirt v2 4/9] remote: Use domainClientEventCallbacks for remoteReplayConnectionClosedEvent

2018-05-07 Thread Marc Hartmayer
On Fri, Apr 27, 2018 at 02:19 AM +0200, John Ferlan wrote: > On 04/26/2018 12:27 PM, Marc Hartmayer wrote: >> On Thu, Apr 26, 2018 at 05:07 PM +0200, John Ferlan >> wrote: >>> On 04/12/2018 08:40 AM, Marc Hartmayer wrote: This allows us to get rid of

Re: [libvirt] [PATCH libvirt v2 4/9] remote: Use domainClientEventCallbacks for remoteReplayConnectionClosedEvent

2018-04-26 Thread John Ferlan
On 04/26/2018 12:27 PM, Marc Hartmayer wrote: > On Thu, Apr 26, 2018 at 05:07 PM +0200, John Ferlan > wrote: >> On 04/12/2018 08:40 AM, Marc Hartmayer wrote: >>> This allows us to get rid of another usage of the global variable >>> remoteProgram. >>> >>> Signed-off-by: Marc

Re: [libvirt] [PATCH libvirt v2 4/9] remote: Use domainClientEventCallbacks for remoteReplayConnectionClosedEvent

2018-04-26 Thread Marc Hartmayer
On Thu, Apr 26, 2018 at 05:07 PM +0200, John Ferlan wrote: > On 04/12/2018 08:40 AM, Marc Hartmayer wrote: >> This allows us to get rid of another usage of the global variable >> remoteProgram. >> >> Signed-off-by: Marc Hartmayer >> Reviewed-by:

Re: [libvirt] [PATCH libvirt v2 4/9] remote: Use domainClientEventCallbacks for remoteReplayConnectionClosedEvent

2018-04-26 Thread John Ferlan
On 04/12/2018 08:40 AM, Marc Hartmayer wrote: > This allows us to get rid of another usage of the global variable > remoteProgram. > > Signed-off-by: Marc Hartmayer > Reviewed-by: Boris Fiuczynski > --- >

[libvirt] [PATCH libvirt v2 4/9] remote: Use domainClientEventCallbacks for remoteReplayConnectionClosedEvent

2018-04-12 Thread Marc Hartmayer
This allows us to get rid of another usage of the global variable remoteProgram. Signed-off-by: Marc Hartmayer Reviewed-by: Boris Fiuczynski --- src/remote/remote_daemon_dispatch.c | 18 ++ 1 file changed, 14