Re: [libvirt] [PATCH python 05/15] generator: Remove use of 'has_key' function

2013-12-04 Thread Daniel P. Berrange
On Tue, Dec 03, 2013 at 04:36:41PM +, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The code 'XXX.has_key()' must be changed to be of the form 'YYY in ' which works in Python2 and 3 Self-NACK. For reasons I don't yet understand this breaks on python 2.4

[libvirt] [PATCH python 05/15] generator: Remove use of 'has_key' function

2013-12-03 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The code 'XXX.has_key()' must be changed to be of the form 'YYY in ' which works in Python2 and 3 Signed-off-by: Daniel P. Berrange berra...@redhat.com --- generator.py | 106 +-- 1

Re: [libvirt] [PATCH python 05/15] generator: Remove use of 'has_key' function

2013-12-03 Thread Doug Goldstein
On Tue, Dec 3, 2013 at 10:36 AM, Daniel P. Berrange berra...@redhat.com wrote: From: Daniel P. Berrange berra...@redhat.com The code 'XXX.has_key()' must be changed to be of the form 'YYY in ' which works in Python2 and 3 Signed-off-by: Daniel P. Berrange berra...@redhat.com ---