[libvirt] [PATCH v2] openvzDomainSetNetwork: use virCommand

2013-05-20 Thread Michal Privoznik
Currently, the openvzDomainSetNetwork function constructs an array of strings representing a command line for VZCTL binary. This is a overkill since our virCommand APIs can cover all the functionality. Moreover, the function is not following our structure where return value is set to -1 initially,

Re: [libvirt] [PATCH v2] openvzDomainSetNetwork: use virCommand

2013-05-20 Thread Michal Privoznik
On 20.05.2013 15:47, Michal Privoznik wrote: Currently, the openvzDomainSetNetwork function constructs an array of strings representing a command line for VZCTL binary. This is a overkill since our virCommand APIs can cover all the functionality. Moreover, the function is not following our

Re: [libvirt] [PATCH v2] openvzDomainSetNetwork: use virCommand

2013-05-20 Thread Ján Tomko
On 05/20/2013 03:49 PM, Michal Privoznik wrote: On 20.05.2013 15:47, Michal Privoznik wrote: Currently, the openvzDomainSetNetwork function constructs an array of strings representing a command line for VZCTL binary. This is a overkill since our virCommand APIs can cover all the

Re: [libvirt] [PATCH v2] openvzDomainSetNetwork: use virCommand

2013-05-20 Thread Eric Blake
On 05/20/2013 07:47 AM, Michal Privoznik wrote: Currently, the openvzDomainSetNetwork function constructs an array of strings representing a command line for VZCTL binary. This is a overkill since our virCommand APIs can cover all the functionality. Moreover, the function is not following our

Re: [libvirt] [PATCH v2] openvzDomainSetNetwork: use virCommand

2013-05-20 Thread Michal Privoznik
On 20.05.2013 17:54, Eric Blake wrote: On 05/20/2013 07:47 AM, Michal Privoznik wrote: Currently, the openvzDomainSetNetwork function constructs an array of strings representing a command line for VZCTL binary. This is a overkill since our virCommand APIs can cover all the functionality.