Re: [libvirt] [PATCH v2] qemu: qemuDomainChangeNet: validity checks should be done before XML autocompletion

2018-08-24 Thread Katerina Koukiou
On Thu, Aug 09, 2018 at 05:50:11PM +0200, Ján Tomko wrote: > On Thu, Aug 09, 2018 at 11:21:52AM +0200, Katerina Koukiou wrote: > > This patch ensures that changes in attributes of interfaces will be emit > > errors accept if they are missing from the XML. > > Previously we were falsely reporting

Re: [libvirt] [PATCH v2] qemu: qemuDomainChangeNet: validity checks should be done before XML autocompletion

2018-08-09 Thread Ján Tomko
On Thu, Aug 09, 2018 at 11:21:52AM +0200, Katerina Koukiou wrote: This patch ensures that changes in attributes of interfaces will be emit errors accept if they are missing from the XML. Previously we were falsely reporting successfull updates, because some *successful changed attributes got

[libvirt] [PATCH v2] qemu: qemuDomainChangeNet: validity checks should be done before XML autocompletion

2018-08-09 Thread Katerina Koukiou
This patch ensures that changes in attributes of interfaces will be emit errors accept if they are missing from the XML. Previously we were falsely reporting successfull updates, because some changed attributes got overwritten before the validity checks.