Re: [libvirt] [PATCH v2] test_driver: properly handle DHCP ranges and IPv6 networks in testDomainInterfaceAddresses

2019-06-21 Thread Michal Privoznik
On 6/21/19 11:49 AM, Ilias Stamatis wrote: > I totally agree with you, it's more readable for me too. Just so far I haven't encountered in the code. Also e.g. C99 allows variables to be declared inside a loop ie for (size_t i = 0; ... ...but I haven't seen that being used anywhere either.

Re: [libvirt] [PATCH v2] test_driver: properly handle DHCP ranges and IPv6 networks in testDomainInterfaceAddresses

2019-06-21 Thread Ilias Stamatis
On Fri, Jun 21, 2019 at 10:03 AM Michal Privoznik wrote: > > On 6/20/19 7:36 PM, Ilias Stamatis wrote: > > On Thu, Jun 20, 2019 at 5:57 PM Michal Privoznik > > wrote: > >> > >> On 6/19/19 6:45 PM, Ilias Stamatis wrote: > >>> testDomainInterfaceAddresses always returns the same hard-coded > >>> a

Re: [libvirt] [PATCH v2] test_driver: properly handle DHCP ranges and IPv6 networks in testDomainInterfaceAddresses

2019-06-21 Thread Michal Privoznik
On 6/20/19 7:36 PM, Ilias Stamatis wrote: On Thu, Jun 20, 2019 at 5:57 PM Michal Privoznik wrote: On 6/19/19 6:45 PM, Ilias Stamatis wrote: testDomainInterfaceAddresses always returns the same hard-coded addresses. Change the behavior such as if there is a DHCP range defined, addresses are re

Re: [libvirt] [PATCH v2] test_driver: properly handle DHCP ranges and IPv6 networks in testDomainInterfaceAddresses

2019-06-20 Thread Ilias Stamatis
On Thu, Jun 20, 2019 at 5:57 PM Michal Privoznik wrote: > > On 6/19/19 6:45 PM, Ilias Stamatis wrote: > > testDomainInterfaceAddresses always returns the same hard-coded > > addresses. Change the behavior such as if there is a DHCP range defined, > > addresses are returned from that pool. > > > >

Re: [libvirt] [PATCH v2] test_driver: properly handle DHCP ranges and IPv6 networks in testDomainInterfaceAddresses

2019-06-20 Thread Michal Privoznik
On 6/19/19 6:45 PM, Ilias Stamatis wrote: testDomainInterfaceAddresses always returns the same hard-coded addresses. Change the behavior such as if there is a DHCP range defined, addresses are returned from that pool. The specific address returned depends on both the domain id and the specific g

[libvirt] [PATCH v2] test_driver: properly handle DHCP ranges and IPv6 networks in testDomainInterfaceAddresses

2019-06-19 Thread Ilias Stamatis
testDomainInterfaceAddresses always returns the same hard-coded addresses. Change the behavior such as if there is a DHCP range defined, addresses are returned from that pool. The specific address returned depends on both the domain id and the specific guest interface in an attempt to return uniqu