[libvirt] [PATCH v2] util: avoid symbol clash between json libraries

2018-08-05 Thread Daniel P . Berrangé
The jansson and json-glib libraries both export symbols with a json_ name prefix and json_object_iter_next() clashes between them. Unfortunately json_glib is linked in by GTK, so any app using GTK and libvirt will get a clash, resulting in SEGV. This also affects the NSS module provided by

Re: [libvirt] [PATCH v2] util: avoid symbol clash between json libraries

2018-08-05 Thread Ján Tomko
On Tue, Jul 31, 2018 at 05:27:36PM +0100, Daniel P. Berrangé wrote: The jansson and json-glib libraries both export symbols with a json_ name prefix and json_object_iter_next() clashes between them. Unfortunately json_glib is linked in by GTK, so any app using GTK and libvirt will get a clash,

Re: [libvirt] [PATCH v2] util: avoid symbol clash between json libraries

2018-07-31 Thread Andrea Bolognani
On Tue, 2018-07-31 at 17:27 +0100, Daniel P. Berrangé wrote: [...] > libvirt_nss_la_LIBADD = \ > - $(JANSSON_LIBS) \ > $(NULL) You can drop libvirt_nss_la_LIBADD altogether now. Reviewed-by: Andrea Bolognani -- Andrea Bolognani / Red Hat / Virtualization --