Re: [libvirt] [PATCH v2] virt-aa-helper: fix parsing security labels

2016-11-29 Thread Guido Günther
On Mon, Nov 28, 2016 at 01:29:02PM +0100, Christian Ehrhardt wrote: > On Tue, Nov 22, 2016 at 8:01 AM, Guido Günther wrote: > > > This looks good to me (and looks more terse now) . It would be great to > > have another review though. > > > > No other eye looking at it over the

Re: [libvirt] [PATCH v2] virt-aa-helper: fix parsing security labels

2016-11-29 Thread Cedric Bosdonnat
Hi Christian, Sorry for being sitting on that one. Your v2 looks good to me. ACK from me. -- Cedric On Mon, 2016-11-28 at 13:29 +0100, Christian Ehrhardt wrote: > > On Tue, Nov 22, 2016 at 8:01 AM, Guido Günther wrote: > > This looks good to me (and looks more terse now) .

Re: [libvirt] [PATCH v2] virt-aa-helper: fix parsing security labels

2016-11-28 Thread Jim Fehlig
On 11/28/2016 05:29 AM, Christian Ehrhardt wrote: On Tue, Nov 22, 2016 at 8:01 AM, Guido Günther > wrote: This looks good to me (and looks more terse now) . It would be great to have another review though. No other eye looking at it over the

Re: [libvirt] [PATCH v2] virt-aa-helper: fix parsing security labels

2016-11-28 Thread Guido Günther
Hi Christian, On Mon, Nov 28, 2016 at 01:29:02PM +0100, Christian Ehrhardt wrote: > On Tue, Nov 22, 2016 at 8:01 AM, Guido Günther wrote: > > > This looks good to me (and looks more terse now) . It would be great to > > have another review though. > > > > No other eye looking

Re: [libvirt] [PATCH v2] virt-aa-helper: fix parsing security labels

2016-11-28 Thread Christian Ehrhardt
On Tue, Nov 22, 2016 at 8:01 AM, Guido Günther wrote: > This looks good to me (and looks more terse now) . It would be great to > have another review though. > No other eye looking at it over the last week :-/ Therefore here another ping to the List. As the common apparmor

Re: [libvirt] [PATCH v2] virt-aa-helper: fix parsing security labels

2016-11-21 Thread Guido Günther
On Mon, Nov 21, 2016 at 03:40:23PM +0100, Christian Ehrhardt wrote: > When virt-aa-helper parses xml content it can fail on security labels. > > It fails by requiring to parse active domain content on seclabels that > is not yet filled in. > > Testcase with virt-aa-helper on a minimal xml: > $

[libvirt] [PATCH v2] virt-aa-helper: fix parsing security labels

2016-11-21 Thread Christian Ehrhardt
When virt-aa-helper parses xml content it can fail on security labels. It fails by requiring to parse active domain content on seclabels that is not yet filled in. Testcase with virt-aa-helper on a minimal xml: $ cat << EOF > /tmp/test.xml test-seclabel