Re: [libvirt] [PATCH v2 0/3] introduce virBufferEscapeN and fix escape bug

2017-02-24 Thread Pavel Hrdina
On Fri, Feb 24, 2017 at 11:53:29AM +0100, Ján Tomko wrote: > On Thu, Feb 23, 2017 at 09:36:15PM +0100, Pavel Hrdina wrote: > >I've dropped the STRCAT patches in v2. The whole purpose of the STRCAT was > >to avoid calling *strcspn* several times but it was probably a bad call. > >Now we call that

Re: [libvirt] [PATCH v2 0/3] introduce virBufferEscapeN and fix escape bug

2017-02-24 Thread Ján Tomko
On Thu, Feb 23, 2017 at 09:36:15PM +0100, Pavel Hrdina wrote: I've dropped the STRCAT patches in v2. The whole purpose of the STRCAT was to avoid calling *strcspn* several times but it was probably a bad call. Now we call that function for each pair but if no escaping is required we at least

[libvirt] [PATCH v2 0/3] introduce virBufferEscapeN and fix escape bug

2017-02-23 Thread Pavel Hrdina
I've dropped the STRCAT patches in v2. The whole purpose of the STRCAT was to avoid calling *strcspn* several times but it was probably a bad call. Now we call that function for each pair but if no escaping is required we at least don't allocate the structure for that pair and later in the