Re: [libvirt] [PATCH v2 01/10] conf: Introduce readonly to hostdev and change helper function

2013-04-08 Thread Laine Stump
On 04/05/2013 05:10 AM, Han Cheng wrote: On 04/02/2013 10:15 AM, Hu Tao wrote: On Mon, Apr 01, 2013 at 08:00:53PM +0800, Han Cheng wrote: diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index edddf25..f8e3973 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@

Re: [libvirt] [PATCH v2 01/10] conf: Introduce readonly to hostdev and change helper function

2013-04-08 Thread Daniel P. Berrange
On Mon, Apr 08, 2013 at 11:13:51AM -0400, Laine Stump wrote: On 04/05/2013 05:10 AM, Han Cheng wrote: On 04/02/2013 10:15 AM, Hu Tao wrote: On Mon, Apr 01, 2013 at 08:00:53PM +0800, Han Cheng wrote: diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index edddf25..f8e3973 100644

Re: [libvirt] [PATCH v2 01/10] conf: Introduce readonly to hostdev and change helper function

2013-04-07 Thread Han Cheng
On 04/05/2013 07:17 PM, Paolo Bonzini wrote: Il 03/04/2013 05:37, Osier Yang ha scritto: codereadonly/code ddIndicates the device is readonly, only valid for SCSI device. span class=sinceSince 1.0.5/span. /dd dtcodeboot/code/dt ddSpecifies that the device is bootable.

Re: [libvirt] [PATCH v2 01/10] conf: Introduce readonly to hostdev and change helper function

2013-04-05 Thread Han Cheng
On 04/02/2013 10:15 AM, Hu Tao wrote: On Mon, Apr 01, 2013 at 08:00:53PM +0800, Han Cheng wrote: diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index edddf25..f8e3973 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -439,6 +439,8 @@ struct _virDomainHostdevDef {

Re: [libvirt] [PATCH v2 01/10] conf: Introduce readonly to hostdev and change helper function

2013-04-05 Thread Paolo Bonzini
Il 03/04/2013 05:37, Osier Yang ha scritto: codereadonly/code ddIndicates the device is readonly, only valid for SCSI device. span class=sinceSince 1.0.5/span. /dd dtcodeboot/code/dt ddSpecifies that the device is bootable. The codeorder/code attribute determines

Re: [libvirt] [PATCH v2 01/10] conf: Introduce readonly to hostdev and change helper function

2013-04-02 Thread Han Cheng
On 04/02/2013 11:02 AM, Han Cheng wrote: On 04/02/2013 10:15 AM, Hu Tao wrote: On Mon, Apr 01, 2013 at 08:00:53PM +0800, Han Cheng wrote: diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index f3fca7f..d9d6b9f 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@

Re: [libvirt] [PATCH v2 01/10] conf: Introduce readonly to hostdev and change helper function

2013-04-02 Thread Osier Yang
On 01/04/13 20:00, Han Cheng wrote: The only parameter in -drive affect scsi-generic is readonly. Introduce readonly/ to hostdev. The helper function to look up disk controller model may be used by scsi hostdev. But it should be changed to use info. Signed-off-by: Han Cheng

[libvirt] [PATCH v2 01/10] conf: Introduce readonly to hostdev and change helper function

2013-04-01 Thread Han Cheng
The only parameter in -drive affect scsi-generic is readonly. Introduce readonly/ to hostdev. The helper function to look up disk controller model may be used by scsi hostdev. But it should be changed to use info. Signed-off-by: Han Cheng hanc.f...@cn.fujitsu.com --- docs/formatdomain.html.in

Re: [libvirt] [PATCH v2 01/10] conf: Introduce readonly to hostdev and change helper function

2013-04-01 Thread Hu Tao
On Mon, Apr 01, 2013 at 08:00:53PM +0800, Han Cheng wrote: The only parameter in -drive affect scsi-generic is readonly. Introduce readonly/ to hostdev. The helper function to look up disk controller model may be used by scsi hostdev. But it should be changed to use info. Signed-off-by: Han

Re: [libvirt] [PATCH v2 01/10] conf: Introduce readonly to hostdev and change helper function

2013-04-01 Thread Han Cheng
On 04/02/2013 10:15 AM, Hu Tao wrote: On Mon, Apr 01, 2013 at 08:00:53PM +0800, Han Cheng wrote: --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -2257,6 +2257,9 @@ codeid/code attribute that specifies the USB vendor and product id. The ids can be given in