Re: [libvirt] [PATCH v2 08/12] esx: set vmfs fs type for vmfs-based datastores

[Cole Robinson]

On 11/15/19 7:40 AM, Pino Toscano wrote:
> This way they are correctly represented:
>   
> 
>   
> ... instead of 'auto'.
> 
> Signed-off-by: Pino Toscano 
> ---
>  src/esx/esx_storage_backend_vmfs.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/esx/esx_storage_backend_vmfs.c 
> b/src/esx/esx_storage_backend_vmfs.c
> index 05b273aed7..1270c21e00 100644
> --- a/src/esx/esx_storage_backend_vmfs.c
> +++ b/src/esx/esx_storage_backend_vmfs.c
> @@ -531,6 +531,7 @@ esxStoragePoolGetXMLDesc(virStoragePoolPtr pool, unsigned 
> int flags)
>  }
>  } else if (esxVI_VmfsDatastoreInfo_DynamicCast(info)) {
>  def.type = VIR_STORAGE_POOL_FS;
> +def.source.format = VIR_STORAGE_POOL_FS_VMFS;
>  /*
>   * FIXME: I'm not sure how to represent the source and target of a
>   * VMFS based datastore in libvirt terms
> 

Reviewed-by: Cole Robinson 

- Cole

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH v2 08/12] esx: set vmfs fs type for vmfs-based datastores

[Pino Toscano]

This way they are correctly represented:
  

  
... instead of 'auto'.

Signed-off-by: Pino Toscano 
---
 src/esx/esx_storage_backend_vmfs.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/esx/esx_storage_backend_vmfs.c 
b/src/esx/esx_storage_backend_vmfs.c
index 05b273aed7..1270c21e00 100644
--- a/src/esx/esx_storage_backend_vmfs.c
+++ b/src/esx/esx_storage_backend_vmfs.c
@@ -531,6 +531,7 @@ esxStoragePoolGetXMLDesc(virStoragePoolPtr pool, unsigned 
int flags)
 }
 } else if (esxVI_VmfsDatastoreInfo_DynamicCast(info)) {
 def.type = VIR_STORAGE_POOL_FS;
+def.source.format = VIR_STORAGE_POOL_FS_VMFS;
 /*
  * FIXME: I'm not sure how to represent the source and target of a
  * VMFS based datastore in libvirt terms
-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list