Re: [libvirt] [PATCH v2 09/12] Add host cache information into capabilities

2017-04-07 Thread Erik Skultety
On Wed, Apr 05, 2017 at 04:36:32PM +0200, Martin Kletzander wrote: > Signed-off-by: Martin Kletzander > --- > I'm adding only info about L3 caches, we can add more later, but for > now that's more than enough. I think it's worth putting this into the commit message, along

Re: [libvirt] [PATCH v2 09/12] Add host cache information into capabilities

2017-04-06 Thread Martin Kletzander
On Thu, Apr 06, 2017 at 02:04:04PM +0800, Eli Qiao wrote: + +VIR_ENUM_IMPL(virCache, VIR_CACHE_TYPE_LAST, + "unified", + "instruction", + "data") + }; +typedef enum { + VIR_CACHE_TYPE_DATA, + VIR_CACHE_TYPE_INSTRUCTION, + VIR_CACHE_TYPE_UNIFIED, + + VIR_CACHE_TYPE_LAST +} virCacheType; +

Re: [libvirt] [PATCH v2 09/12] Add host cache information into capabilities

2017-04-06 Thread Eli Qiao
> + > +VIR_ENUM_IMPL(virCache, VIR_CACHE_TYPE_LAST, > + "unified", > + "instruction", > + "data") > + > }; > > +typedef enum { > + VIR_CACHE_TYPE_DATA, > + VIR_CACHE_TYPE_INSTRUCTION, > + VIR_CACHE_TYPE_UNIFIED, > + > + VIR_CACHE_TYPE_LAST > +} virCacheType; > + The sequence is wrong, it

[libvirt] [PATCH v2 09/12] Add host cache information into capabilities

2017-04-05 Thread Martin Kletzander
Signed-off-by: Martin Kletzander --- I'm adding only info about L3 caches, we can add more later, but for now that's more than enough. src/conf/capabilities.c | 200 src/conf/capabilities.h | 29