Re: [libvirt] [PATCH v2 1/2] security_manager: Don't manipulate domain XML in virDomainDefGetSecurityLabelDef

2013-03-28 Thread Daniel P. Berrange
On Thu, Mar 21, 2013 at 04:35:10PM +0100, Michal Privoznik wrote: The virDomainDefGetSecurityLabelDef was modifying the domain XML. It tried to find a seclabel corresponding to given sec driver. If the label wasn't found, the function created one which is wrong. In fact it's security manager

Re: [libvirt] [PATCH v2 1/2] security_manager: Don't manipulate domain XML in virDomainDefGetSecurityLabelDef

2013-03-28 Thread Michal Privoznik
On 28.03.2013 10:15, Daniel P. Berrange wrote: On Thu, Mar 21, 2013 at 04:35:10PM +0100, Michal Privoznik wrote: The virDomainDefGetSecurityLabelDef was modifying the domain XML. It tried to find a seclabel corresponding to given sec driver. If the label wasn't found, the function created one

Re: [libvirt] [PATCH v2 1/2] security_manager: Don't manipulate domain XML in virDomainDefGetSecurityLabelDef

2013-03-28 Thread Daniel P. Berrange
On Thu, Mar 28, 2013 at 10:42:39AM +0100, Michal Privoznik wrote: On 28.03.2013 10:15, Daniel P. Berrange wrote: On Thu, Mar 21, 2013 at 04:35:10PM +0100, Michal Privoznik wrote: The virDomainDefGetSecurityLabelDef was modifying the domain XML. It tried to find a seclabel corresponding to

[libvirt] [PATCH v2 1/2] security_manager: Don't manipulate domain XML in virDomainDefGetSecurityLabelDef

2013-03-21 Thread Michal Privoznik
The virDomainDefGetSecurityLabelDef was modifying the domain XML. It tried to find a seclabel corresponding to given sec driver. If the label wasn't found, the function created one which is wrong. In fact it's security manager which should modify this part of domain XML. ---